-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: removed unused component #26000
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
The WrongNetworkNotification
component and its associated files have been removed due to being unused.
- Deleted
ui/components/institutional/wrong-network-notification/index.js
- Removed
ui/components/institutional/wrong-network-notification/index.scss
- Removed
ui/components/institutional/wrong-network-notification/wrong-network-notification.js
- Deleted
ui/components/institutional/wrong-network-notification/wrong-network-notification.stories.js
- Removed
ui/components/institutional/wrong-network-notification/wrong-network-notification.test.js
Ensure this component is not referenced elsewhere to avoid runtime errors.
5 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
The pull request focuses on removing the unused WrongNetworkNotification
component and includes several other changes to improve the MetaMask extension's functionality and test coverage.
- Removed Unused Component: Deleted
WrongNetworkNotification
and associated files. - Sentry Integration: Added
redesignedConfirmationsEnabled
property inapp/scripts/lib/setupSentry.js
. - Refactored Keyring Handling: Replaced
withKeyringForDevice
withgetKeyringForDevice
inapp/scripts/metamask-controller.js
. - Migration Script: Added migration script
app/scripts/migrations/122.ts
to setredesignedConfirmationsEnabled
totrue
. - Enhanced Test Coverage: Added
tempToggleSettingRedesignedConfirmations
helper function across multiple test files to ensure redesigned confirmations are tested.
22 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Builds ready [8c7255a]
Page Load Metrics (322 ± 277 ms)
Bundle size diffs
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
The pull request removes the unused WrongNetworkNotification
component and includes several other changes to improve the MetaMask extension's functionality and test coverage.
- Removed Unused Component: Deleted
WrongNetworkNotification
and associated files. - CI Pipeline Update: Removed
test-e2e-swap-playwright
job from.circleci/config.yml
to streamline the CI process. - Test-Specific Overrides: Introduced test-specific overrides for keyring bridges in
app/scripts/background.js
. - Mock Data Addition: Added
SWAP_TEST_ETH_USDC_TRADES_MOCK
intest/data/mock-data.js
for enhanced test scenarios. - URL Parameter Updates: Updated various test files to include
metricsEnabled=false
andmarketingEnabled=false
query parameters.
27 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Builds ready [676cc42]
Page Load Metrics (262 ± 282 ms)
Bundle size diffs
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #26000 +/- ##
===========================================
- Coverage 69.69% 69.68% -0.01%
===========================================
Files 1405 1404 -1
Lines 49723 49713 -10
Branches 13740 13735 -5
===========================================
- Hits 34650 34640 -10
Misses 15073 15073 ☔ View full report in Codecov by Sentry. |
Description
WrongNetworkNotification it’s not used anywhere and we can remove it from the extension.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist