Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removed unused component #26000

Merged
merged 4 commits into from
Jul 24, 2024
Merged

Conversation

albertolive
Copy link
Contributor

@albertolive albertolive commented Jul 22, 2024

Description

WrongNetworkNotification it’s not used anywhere and we can remove it from the extension.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@albertolive albertolive added the team-mmi PRs from the MMI team label Jul 22, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@albertolive albertolive marked this pull request as ready for review July 22, 2024 12:30
@albertolive albertolive requested a review from a team as a code owner July 22, 2024 12:30
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

The WrongNetworkNotification component and its associated files have been removed due to being unused.

  • Deleted ui/components/institutional/wrong-network-notification/index.js
  • Removed ui/components/institutional/wrong-network-notification/index.scss
  • Removed ui/components/institutional/wrong-network-notification/wrong-network-notification.js
  • Deleted ui/components/institutional/wrong-network-notification/wrong-network-notification.stories.js
  • Removed ui/components/institutional/wrong-network-notification/wrong-network-notification.test.js

Ensure this component is not referenced elsewhere to avoid runtime errors.

5 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

The pull request focuses on removing the unused WrongNetworkNotification component and includes several other changes to improve the MetaMask extension's functionality and test coverage.

  • Removed Unused Component: Deleted WrongNetworkNotification and associated files.
  • Sentry Integration: Added redesignedConfirmationsEnabled property in app/scripts/lib/setupSentry.js.
  • Refactored Keyring Handling: Replaced withKeyringForDevice with getKeyringForDevice in app/scripts/metamask-controller.js.
  • Migration Script: Added migration script app/scripts/migrations/122.ts to set redesignedConfirmationsEnabled to true.
  • Enhanced Test Coverage: Added tempToggleSettingRedesignedConfirmations helper function across multiple test files to ensure redesigned confirmations are tested.

22 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@metamaskbot
Copy link
Collaborator

Builds ready [8c7255a]
Page Load Metrics (322 ± 277 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint804651308039
domContentLoaded116433157
load471781322578277
domInteractive116333157
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

The pull request removes the unused WrongNetworkNotification component and includes several other changes to improve the MetaMask extension's functionality and test coverage.

  • Removed Unused Component: Deleted WrongNetworkNotification and associated files.
  • CI Pipeline Update: Removed test-e2e-swap-playwright job from .circleci/config.yml to streamline the CI process.
  • Test-Specific Overrides: Introduced test-specific overrides for keyring bridges in app/scripts/background.js.
  • Mock Data Addition: Added SWAP_TEST_ETH_USDC_TRADES_MOCK in test/data/mock-data.js for enhanced test scenarios.
  • URL Parameter Updates: Updated various test files to include metricsEnabled=false and marketingEnabled=false query parameters.

27 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@metamaskbot
Copy link
Collaborator

Builds ready [676cc42]
Page Load Metrics (262 ± 282 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint713171156732
domContentLoaded999252010
load402311262587282
domInteractive999252010
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.68%. Comparing base (5272c59) to head (676cc42).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #26000      +/-   ##
===========================================
- Coverage    69.69%   69.68%   -0.01%     
===========================================
  Files         1405     1404       -1     
  Lines        49723    49713      -10     
  Branches     13740    13735       -5     
===========================================
- Hits         34650    34640      -10     
  Misses       15073    15073              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albertolive albertolive merged commit 92a2721 into develop Jul 24, 2024
76 checks passed
@albertolive albertolive deleted the MMI-5289-remove-unused-component branch July 24, 2024 08:40
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2024
@metamaskbot metamaskbot added the release-12.3.0 Issue or pull request that will be included in release 12.3.0 label Jul 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-mmi PRs from the MMI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants