-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrated institutional ui components to ts #25858
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
onChange: () => { | ||
/**/ | ||
}, | ||
}, | ||
}; | ||
|
||
export const DefaultStory = (args) => <NoteToTrader {...args} />; | ||
export const DefaultStory = (args: any) => <NoteToTrader {...args} />; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case we can define a type instead of any from observing the args
values above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pedronfigueiredo changes are done
@metamaskbot update-policies |
Policies updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should try to remove the remaining any
declarations, see the contributor docs for more info, and follow a recent thread on this.
@pedronfigueiredo I already removed all of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Migrated institutional UI components to TypeScript for improved type safety and maintainability.
- Updated
lavamoat/browserify/mmi/policy.json
to simplify dependency paths for@metamask-institutional/types
. - Added
@metamask-institutional/types
dependency inpackage.json
. - Migrated
ui/components/institutional/confirm-remove-jwt-modal/*
files to TypeScript, ensuring type safety and consistency. - Migrated
ui/components/institutional/custody-confirm-link-modal/*
files to TypeScript, enhancing type definitions and maintainability. - Migrated
ui/components/institutional/interactive-replacement-token-modal/*
files to TypeScript, improving type annotations and reducing runtime errors.
27 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
Migrated institutional UI components to TypeScript for improved type safety and maintainability.
- Added
app/scripts/migrations/122.ts
to enableredesignedConfirmationsEnabled
by default. - Updated
app/scripts/metamask-controller.js
to refactor hardware wallet keyring handling. - Enhanced
test/e2e/helpers.js
withtempToggleSettingRedesignedConfirmations
for redesigned confirmation tests. - Modified
app/scripts/lib/setupSentry.js
to trackredesignedConfirmationsEnabled
in Sentry. - Updated
test/e2e/tests/*
to include redesigned confirmation settings in various test cases.
22 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Builds ready [eeba795]
Page Load Metrics (155 ± 150 ms)
Bundle size diffs
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
Migrated institutional UI components to TypeScript for improved type safety and maintainability.
- Updated
ui/components/institutional/*
to TypeScript, enhancing type safety. - Modified
app/scripts/background.js
to include test-specific keyring overrides. - Added
test/stub/keyring-bridge.js
for simulating keyring bridges in tests. - Updated
ui/pages/asset/components/token-buttons.tsx
to TypeScript, including MetaMetrics and marketing data selectors. - Removed
test-e2e-swap-playwright
job from.circleci/config.yml
, potentially reducing test coverage but streamlining CI pipeline.
27 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Builds ready [bc73047]
Page Load Metrics (251 ± 246 ms)
Bundle size diffs
|
Description
Most of our components are still written in JS; there’s nothing wrong with that, but since MM has been making an effort to move their components to TS and all our new UI pieces are written in TS, we should start moving our UI elements to TS, starting from:
ui/components/institutional/
AC:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist