Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve error messages #232

Merged
merged 7 commits into from
Jul 12, 2024
Merged

refactor: improve error messages #232

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
718da53
fix: Currently ledger keyring throw `unknown error` when user didn't …
dawnseeker8 Jul 3, 2024
612fa68
fix: Currently ledger keyring throw `unknown error` when user lock le…
dawnseeker8 Jul 8, 2024
66fb23a
fix: Currently ledger keyring throw `unknown error` when user lock le…
dawnseeker8 Jul 8, 2024
141f013
Merge branch 'main' into fix/unknown-error-in-extensions
dawnseeker8 Jul 11, 2024
b2505bb
feat: Remove duplicate tests.
dawnseeker8 Jul 11, 2024
c75965d
feat: Change the error message to `Ledger Ethereum app closed. Open i…
dawnseeker8 Jul 12, 2024
27bbbcd
feat: Change the error message to `Ledger Ethereum app closed. Open i…
dawnseeker8 Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,3 +76,6 @@ node_modules/
!.yarn/releases
!.yarn/sdks
!.yarn/versions

# exclude webstorm profile file
.idea/
gantunesr marked this conversation as resolved.
Show resolved Hide resolved
4 changes: 3 additions & 1 deletion src/ledger-keyring.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,9 @@ describe('LedgerKeyring', function () {
it('throws an error when the bridge getPublicKey method throws an error and it is not an error type', async function () {
keyring.setHdPath(`m/44'/60'/0'/0`);
jest.spyOn(bridge, 'getPublicKey').mockRejectedValue('Some error');
await expect(keyring.unlock()).rejects.toThrow('Unknown error');
await expect(keyring.unlock()).rejects.toThrow(
'Unlock your Ledger device and open the ETH app',
);
});
});

Expand Down
4 changes: 3 additions & 1 deletion src/ledger-keyring.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,9 @@ export class LedgerKeyring extends EventEmitter {
hdPath: path,
});
} catch (error) {
throw error instanceof Error ? error : new Error('Unknown error');
throw error instanceof Error
? error
: new Error('Unlock your Ledger device and open the ETH app');
gantunesr marked this conversation as resolved.
Show resolved Hide resolved
}

if (updateHdk && payload.chainCode) {
Expand Down
Loading