refactor: improve error messages #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…turn on `eth` app in ledger. this code change provide better error message to indicate what happen.
…dger or didn't turn on `eth` app in ledger in MM extension. this code change provide better error message to indicate what happen.
…dger or didn't turn on `eth` app in ledger in MM extension. this code change provide better error message to indicate what happen.
gantunesr
changed the title
gantunesr
reviewed
Jul 9, 2024
gantunesr
previously approved these changes
Jul 11, 2024
gantunesr
approved these changes
Jul 12, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
ledger-keyringthrows the errorunknown errorwhen user locks their ledger or didn't turn open theethapp in ledger in MM extension. This PR changes to provide a better error message to indicate what happen.