Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove global network from transaction controller #4920

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions packages/transaction-controller/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,25 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Added

- **BREAKING:** Remove global network usage ([#4920](https://github.com/MetaMask/core/pull/4920))
- Add required `networkClientId` argument to `handleMethodData` method.

### Changed

- **BREAKING:** Remove global network usage ([#4920](https://github.com/MetaMask/core/pull/4920))
- Require `networkClientId` option in `addTransaction` method.
- Require `networkClientId` property in `TransactionMeta` type.
- Change `wipeTransactions` method arguments to optional object containing `address` and `chainId` properties.
- Require `networkClientId` argument in `estimateGas`, `estimateGasBuffered` and `getNonceLock` methods.

### Removed

- **BREAKING:** Remove global network usage ([#4920](https://github.com/MetaMask/core/pull/4920))
- Remove the `blockTracker`, `isMultichainEnabled`, `onNetworkStateChange` and `provider` constructor options.
- Remove `filterToCurrentNetwork` option from `getTransactions` method.

## [40.1.0]

### Added
Expand Down
8 changes: 4 additions & 4 deletions packages/transaction-controller/jest.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ module.exports = merge(baseConfig, {
// An object that configures minimum threshold enforcement for coverage results
coverageThreshold: {
global: {
branches: 93.57,
functions: 97.56,
lines: 98.38,
statements: 98.39,
branches: 93.23,
functions: 97.61,
lines: 98.26,
statements: 98.28,
},
},

Expand Down
Loading
Loading