refactor: remove global network from transaction controller #4920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove multichain flag. Remove provider and block tracker constructor options. Temporarily disable handleMethodData method. Remove unnecessary unit tests. Fix unit tests.
Fix logging in multichain helper. Change wipeTransactions arguments to object.
Remove stopAllIncomingTransactionPolling method. Create separate helper loggers per chain.
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
pedronfigueiredo
previously approved these changes
Nov 21, 2024
OGPoyraz
previously approved these changes
Nov 25, 2024
matthewwalsh0
dismissed stale reviews from OGPoyraz and pedronfigueiredo
via
1137319
matthewwalsh0
requested review from
OGPoyraz and
pedronfigueiredo
and removed request for
OGPoyraz
OGPoyraz
previously approved these changes
Nov 26, 2024
pedronfigueiredo
previously approved these changes
Nov 26, 2024
pedronfigueiredo
approved these changes
Nov 26, 2024
|
@metamaskbot publish-preview |
matthewwalsh0
deleted the
refactor/transaction-controller-remove-global-network
branch
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Remove all global network usage from the
@metamask/transaction-controllerpackage.Specifically:
blockTrackerisMultichainEnabledonNetworkStateChangeprovidernetworkClientIdoption in calls toaddTransaction.networkClientIdrequired inTransactionMetatype.PendingTransactionTrackerIncomingTransactionHelperNonceTracker.wipeTransactionsmethod arguments with object containing optionalchainIdandaddressproperties.networkClientIdargument in:getNonceLockestimateGasestimateGasBufferedfilterToCurrentNetworkoption fromgetTransactionsmethod.networkClientIdargument tohandleMethodDatamethod.MethodDataHelperto encapsulatehandleMethodDatamethod logic.getProviderandgetEthQuerymethods withgetNetworkClientmethod inMultichainTrackingHelper.PendingTransactionTrackerandIncomingTransactionHelper.MultichainTrackingHelperwith additional logs.References
Changelog
See
CHANGELOG.md.Checklist