Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allows gunEmplacement to be converted to Alpha Strike #6289

Merged
merged 6 commits into from
Dec 20, 2024
Merged

feat: allows gunEmplacement to be converted to Alpha Strike #6289

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4249ac7
feat: allows gunEmplacement to be converted to Alpha Strike
Scoppio Dec 19, 2024
89f5448
Merge branch 'master' into feat/unnoficial-as-convert-gunemplacement
Scoppio Dec 19, 2024
99564d3
Update ASConverter.java
Scoppio Dec 19, 2024
8eb79b0
Update ASConverter.java
Scoppio Dec 20, 2024
a48700d
Merge branch 'master' into feat/unnoficial-as-convert-gunemplacement
Scoppio Dec 20, 2024
d326780
Merge branch 'master' into feat/unnoficial-as-convert-gunemplacement
Scoppio Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions megamek/src/megamek/common/alphaStrike/conversion/ASConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,14 +206,16 @@ public ConversionData(Entity entity, AlphaStrikeElement element, CalculationRepo
/**
* Returns true if the given entity can be converted to AlphaStrike. This is
* only
* false for entities of some special types such as TeleMissile or
* GunEmplacement.
* false for entities of some special types such as TeleMissile.
* GunEmplacement can is being allowed conversion as of 50.02 even though its not
Scoppio marked this conversation as resolved.
Show resolved Hide resolved
* currently officially supported in rules as written, but it generates a valid unit that can be used in
* auto-resolution and other parts of the game. (Luana Coppio)
* Also returns false if entity is null.
*/
public static boolean canConvert(@Nullable Entity entity) {
return !(entity == null) && !((entity instanceof TeleMissile) || (entity instanceof FighterSquadron)
|| (entity instanceof EscapePods) || (entity instanceof EjectedCrew)
|| (entity instanceof ArmlessMek) || (entity instanceof GunEmplacement));
|| (entity instanceof ArmlessMek));
}

/**
Expand Down
Loading