feat: allows gunEmplacement to be converted to Alpha Strike #6289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6289 +/- ##
============================================
- Coverage 28.95% 28.95% -0.01%
+ Complexity 14033 14031 -2
============================================
Files 2672 2672
Lines 269237 269238 +1
Branches 47913 47913
============================================
- Hits 77966 77964 -2
- Misses 187370 187372 +2
- Partials 3901 3902 +1 ☔ View full report in Codecov by Sentry. |
Sleet01
reviewed
Dec 20, 2024
megamek/src/megamek/common/alphaStrike/conversion/ASConverter.java
Outdated
Show resolved
Hide resolved
Sleet01
approved these changes
Dec 20, 2024
HammerGS
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am enabling the conversion of GunEmplacement to Alpha Strike element as even it not being covered by rules as written, it is possible to use it as is to create a valid unit, and ACAR does need it to run scenarios in facilities.