Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 6252: Offboard Artillery cannot unjam critted weapons #6286

Conversation

psikomonkie
Copy link
Collaborator

@psikomonkie psikomonkie commented Dec 18, 2024

Fixes #6252

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.95%. Comparing base (1b7af87) to head (c307bf0).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6286      +/-   ##
============================================
- Coverage     28.95%   28.95%   -0.01%     
- Complexity    14016    14017       +1     
============================================
  Files          2672     2672              
  Lines        269229   269258      +29     
  Branches      47911    47918       +7     
============================================
+ Hits          77950    77951       +1     
- Misses       187379   187406      +27     
- Partials       3900     3901       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psikomonkie
Copy link
Collaborator Author

Added support for princess.

@psikomonkie psikomonkie marked this pull request as ready for review December 19, 2024 00:44
Copy link
Collaborator

@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; appreciate the Princess update too!

@HammerGS HammerGS merged commit 300f953 into MegaMek:master Dec 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offboard artillery cannot unjam critted weapons
3 participants