Issue 6252: Offboard Artillery cannot unjam critted weapons #6255
Conversation
…aling with searching multiple parent factions to avoid messy truncated integers.
…g total model weight which includes +/- dynamic adjustment and role-based adjustment.
…r offsets pre-production models and initial production limits
…tter interpolation processing
…doubles instead of in, due to 2^(n/2) generating non-integers on odd values of n
…ication of salvage percentage to conventional math.
…or re-balancing Omni-unit proportions.
…due to complexity of managing multiple factors, including salvage.
…otential conflicting data as well as results that are out of line with provided data.
…oads' into issue-1619-rfe-dirt-and-gravel-roads # Conflicts: # megamek/src/megamek/common/Hex.java # megamek/src/megamek/common/MoveStep.java # megamek/src/megamek/common/Terrains.java
allow aerospace to flee with remaining movement
feat: config interface extracted
Issue 6264: Destroyed Infantry no longer have negative weight
Abstract Combat Auto Resolve
…-tools fix: following suggestions of improvements from SJuliez
This reverts commit eeb85bc.
…ot-unjam-critted-weapons' into issue-6252-offmap-artillery-cannot-unjam-critted-weapons
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| private JComponent getArgumentComponent(Argument<?> argument) { | ||
| if (argument instanceof CoordXArgument intArg) { |
Check notice
Code scanning / CodeQL
Chain of 'instanceof' tests Note
| 1)); | ||
| } | ||
|
|
||
| private JSpinner createSpinner(CoordXArgument coordX) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
| 1)); | ||
| } | ||
|
|
||
| private JSpinner createSpinner(CoordYArgument coordY) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
| 1)); | ||
| } | ||
|
|
||
| private JComboBox<String> createPlayerComboBox(PlayerArgument playerArgument) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
| return comboBox; | ||
| } | ||
|
|
||
| private JComboBox<String> createUnitComboBox(UnitArgument unitArgument) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
| return comboBox; | ||
| } | ||
|
|
||
| private JComboBox<String> createTeamsComboBox(TeamArgument teamArgument) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
|
@psikomonkie What is even going on with this issue's history? 😄 |
@Sleet01 Just git skill issues. This was just supposed to be 83fe08f. I don't know how I pushed 13d1eab, which reverted it. When I tried to get this PR ready today after verifying my fix actually works, it went to heck. I opened a new PR from a new branch: #6286 |
Fixes #6252
I tested that artillery targeting still works, but I don't have an easy way to get the weapon crit on an offmap artillery, so I'm opening this as a draft.