Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for job with a callable as a kwarg #51

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Jan 26, 2024

Related to #44 and builds atop #32, showing how callables can be used as keyword arguments to jobs. Note that this doesn't seem to work for lambdas (see the default kwarg for jobflow_remote.testing.arithmetic).

Closes #45.

@ml-evs ml-evs force-pushed the ml-evs/add-callable-test branch from fa38416 to e230763 Compare January 26, 2024 13:42
src/__init__.py Outdated Show resolved Hide resolved
@ml-evs ml-evs force-pushed the ml-evs/add-callable-test branch from e230763 to 8211972 Compare January 28, 2024 14:27
@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (7ffb688) 44.32% compared to head (9b59171) 44.33%.

Files Patch % Lines
src/jobflow_remote/testing/__init__.py 50.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #51   +/-   ##
========================================
  Coverage    44.32%   44.33%           
========================================
  Files           42       42           
  Lines         4259     4265    +6     
  Branches       866      868    +2     
========================================
+ Hits          1888     1891    +3     
- Misses        2189     2192    +3     
  Partials       182      182           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ml-evs ml-evs mentioned this pull request Jan 28, 2024
5 tasks
@ml-evs ml-evs force-pushed the ml-evs/add-callable-test branch from 8211972 to 9b59171 Compare January 29, 2024 17:58
@ml-evs ml-evs marked this pull request as ready for review January 29, 2024 17:59
@ml-evs ml-evs added the testing For issues/PRs relating to testing label Jan 29, 2024
@ml-evs ml-evs merged commit 6dafdd2 into develop Jan 29, 2024
5 checks passed
@ml-evs ml-evs deleted the ml-evs/add-callable-test branch March 26, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing For issues/PRs relating to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for Jobs with a function arg or kwarg
3 participants