Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for Jobs with a function arg or kwarg #45

Closed
Andrew-S-Rosen opened this issue Dec 13, 2023 · 1 comment · Fixed by #51
Closed

Add tests for Jobs with a function arg or kwarg #45

Andrew-S-Rosen opened this issue Dec 13, 2023 · 1 comment · Fixed by #51

Comments

@Andrew-S-Rosen
Copy link
Collaborator

See discussion in #44. Just opening this as a separate issue so @davidwaroquiers' comment doesn't get lost.
@ml-evs
Copy link
Member

ml-evs commented Jan 30, 2024

Whoops, didn't see this other issue. I think my PR #51 should close this for you @Andrew-S-Rosen? The only thing that came up is the standard caveat that the function arg must be importable and cannot be e.g., a lambda. Feel free to reopen if my test case isn't sufficient!

@ml-evs ml-evs closed this as completed Jan 30, 2024
@ml-evs ml-evs mentioned this issue Jan 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add integration test for job with a callable as a kwarg Matgenix/jobflow-remote
2 participants
@ml-evs @Andrew-S-Rosen