Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor readers xi #256

Open
wants to merge 19 commits into
base: refactor_readers_X
Choose a base branch
from
Open

Refactor readers xi #256

wants to merge 19 commits into from
+185 −136

Conversation

mschwoer
Copy link
Contributor

somehow github got stuck on the original PR: #253

  • simplifying the inheritance structure and avoid overwriting superclass methods with pass
  • get rid of obsolete checks on empty origin_df
  • get rid of _transform_table
  • drop hardcoding of "EG.PrecursorId"
  • move test_data_downloader.py to tools/data_downloader.py

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@mschwoer mschwoer mentioned this pull request Nov 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgWa GeorgWa Awaiting requested review from GeorgWa

@jalew188 jalew188 Awaiting requested review from jalew188

@lucas-diedrich lucas-diedrich Awaiting requested review from lucas-diedrich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mschwoer