Fullbox

src/makielayout/blocks/axis3d.jl

@@ -404,7 +404,7 @@ function add_gridlines_and_frames!(topscene, scene, ax, dim::Int, limits, tickno
         visible = attr(:gridvisible), inspectable = false)
 
 
-    framepoints = lift(limits, scene.camera.projectionview, scene.viewport, min1, min2, xreversed, yreversed, zreversed
+    framepoints_main = lift(limits, scene.camera.projectionview, scene.viewport, min1, min2, xreversed, yreversed, zreversed
             ) do lims, _, pxa, mi1, mi2, xrev, yrev, zrev
         o = pxa.origin
 
@@ -427,27 +427,60 @@ function add_gridlines_and_frames!(topscene, scene, ax, dim::Int, limits, tickno
         # we are going to transform the 3d frame points into 2d of the topscene
         # because otherwise the frame lines can
         # be cut when they lie directly on the scene boundary
-        to_topscene_z_2d.([p1, p2, p3, p4, p5, p6], Ref(scene))
+        to_topscene_small_z_2d.([p1, p2, p3, p4, p5, p6], Ref(scene))
+    end
+    framepoints_fullbox = lift(limits, scene.camera.projectionview, scene.viewport, min1, min2, xreversed, yreversed, zreversed
+            ) do lims, _, pxa, mi1, mi2, xrev, yrev, zrev
+        o = pxa.origin
+
+        rev1 = (xrev, yrev, zrev)[d1]
+        rev2 = (xrev, yrev, zrev)[d2]
+
+        mi1 = mi1 ⊻ rev1
+        mi2 = mi2 ⊻ rev2
+
+        f(mi) = mi ? minimum : maximum
+
+        p7 = dpoint(minimum(lims)[dim], f(!mi1)(lims)[d1], f(!mi2)(lims)[d2])
+        p8 = dpoint(maximum(lims)[dim], f(!mi1)(lims)[d1], f(!mi2)(lims)[d2])
+
+        # we are going to transform the 3d frame points into 2d of the topscene
+        # because otherwise the frame lines can
+        # be cut when they lie directly on the scene boundary
+        to_topscene_big_z_2d.([p7, p8], Ref(scene))
     end
     colors = Observable{Any}()
     map!(vcat, colors, attr(:spinecolor_1), attr(:spinecolor_2), attr(:spinecolor_3))
-    framelines = linesegments!(topscene, framepoints, color = colors, linewidth = attr(:spinewidth),
+    framelines = linesegments!(topscene, framepoints_main, color = colors, linewidth = attr(:spinewidth),
         # transparency = true,
         visible = attr(:spinesvisible), inspectable = false)
-
+        if ax.fullbox[] == true
+            framelines = linesegments!(topscene, framepoints_fullbox, color = attr(:spinecolor_4), linewidth = attr(:spinewidth),
+                # transparency = true,
+                visible = attr(:spinesvisible), inspectable = false)
+        end
     return gridline1, gridline2, framelines
 end
 
 # this function projects a point from a 3d subscene into the parent space with a really
 # small z value
-function to_topscene_z_2d(p3d, scene)
+function to_topscene_small_z_2d(p3d, scene)
     o = scene.viewport[].origin
     p2d = Point2f(o + Makie.project(scene, p3d))
     # -10000 is an arbitrary weird constant that in preliminary testing didn't seem
     # to clip into plot objects anymore
     Point3f(p2d..., -10000)
 end
 
+# this function projects a point from a 3d subscene into the parent space with a really
+# big z value
+function to_topscene_big_z_2d(p3d, scene)
+    o = scene.viewport[].origin
+    p2d = Point2f(o + Makie.project(scene, p3d))
+    Point3f(p2d..., 10000)
+end
+
+
 function add_ticks_and_ticklabels!(topscene, scene, ax, dim::Int, limits, ticknode, miv, min1, min2, azimuth, xreversed, yreversed, zreversed)
 
     dimsym(sym) = Symbol(string((:x, :y, :z)[dim]) * string(sym))
@@ -507,7 +540,7 @@ function add_ticks_and_ticklabels!(topscene, scene, ax, dim::Int, limits, tickno
     # be cut when they extend beyond the scene boundary
     tick_segments_2dz = lift(topscene, tick_segments, scene.camera.projectionview, scene.viewport) do ts, _, _
         map(ts) do p1_p2
-            to_topscene_z_2d.(p1_p2, Ref(scene))
+            to_topscene_small_z_2d.(p1_p2, Ref(scene))
         end
     end
 

src/makielayout/types.jl

@@ -1695,7 +1695,15 @@ end
         "The color of y spine 3 opposite of the ticks"
         yspinecolor_3 = :black
         "The color of z spine 3 opposite of the ticks"
-        zspinecolor_3 = :black
+        zspinecolor_3 = :black       
+        "Controls if the 4. Spines are created to close the outline box"
+        fullbox = false
+        "The color of x spine 4"
+        xspinecolor_4 = :black
+        "The color of y spine 4"
+        yspinecolor_4 = :black
+        "The color of z spine 4"
+        zspinecolor_4 = :black
         "The x spine width"
         xspinewidth = 1
         "The y spine width"

src/themes/theme_black.jl

@@ -31,6 +31,9 @@ function theme_black()
             xspinecolor_3 = :white,
             yspinecolor_3 = :white,
             zspinecolor_3 = :white,
+            xspinecolor_4 = :white,
+            yspinecolor_4 = :white,
+            zspinecolor_4 = :white,
             xticklabelpad = 3,
             yticklabelpad = 3,
             zticklabelpad = 6,