Fullbox

CHANGELOG.md

@@ -20,6 +20,7 @@
 - Added `transform_marker` attribute to meshscatter and changed the default behavior to not transform marker/mesh vertices [#4606](https://github.com/MakieOrg/Makie.jl/pull/4606)
 - Fixed some issues with meshscatter not correctly transforming with transform functions and float32 rescaling [#4606](https://github.com/MakieOrg/Makie.jl/pull/4606)
 - Fixed `poly` pipeline for 3D and/or Float64 polygons that begin from an empty vector [#4615](https://github.com/MakieOrg/Makie.jl/pull/4615).
+- Added option to display the front spines in Axis3 to close the outline box [#2349](https://github.com/MakieOrg/Makie.jl/pull/4305)
 
 ## [0.21.18] - 2024-12-12
 

ReferenceTests/src/tests/figures_and_makielayout.jl

@@ -306,6 +306,27 @@ end
     f
 end
 
+@reference_test "Axis3 fullbox" begin
+    f = Figure(size = (400, 400))
+    a = Axis3(f[1, 1], front_spines = true, xspinewidth = 5, yspinewidth = 5, zspinewidth = 5)
+    mesh!(a, Sphere(Point3f(0), 1f0), color = :darkgray)
+
+    for ((x, y), viskey, colkey) in zip([(1,2), (2,1), (2,2)], [:x, :y, :z], [:y, :z, :x])
+        kwargs = Dict(
+            Symbol(viskey, :spinesvisible) => false,
+            Symbol(colkey, :spinecolor_1) => :red,
+            Symbol(colkey, :spinecolor_2) => :green,
+            Symbol(colkey, :spinecolor_3) => :blue,
+            Symbol(colkey, :spinecolor_4) => :orange,
+        )
+        a = Axis3(
+            f[x, y], title = "$viskey hidden, $colkey colored", front_spines = true,
+            xspinewidth = 5, yspinewidth = 5, zspinewidth = 5; kwargs...)
+        mesh!(a, Sphere(Point3f(0), 1f0), color = :darkgray)
+    end
+    f
+end
+
 @reference_test "Axis3 viewmodes, xreversed, aspect, perspectiveness" begin
     fig = Figure(size = (800, 1200))
 

src/makielayout/blocks/axis3d.jl

@@ -456,17 +456,37 @@ function add_gridlines_and_frames!(topscene, scene, ax, dim::Int, limits, tickno
         p4 = dpoint(maximum(lims)[dim], f(mi1)(lims)[d1], f(mi2)(lims)[d2])
         p5 = dpoint(minimum(lims)[dim], f(mi1)(lims)[d1], f(!mi2)(lims)[d2])
         p6 = dpoint(maximum(lims)[dim], f(mi1)(lims)[d1], f(!mi2)(lims)[d2])
-        # p7 = dpoint(minimum(lims)[dim], f(!mi1)(lims)[d1], f(!mi2)(lims)[d2])
-        # p8 = dpoint(maximum(lims)[dim], f(!mi1)(lims)[d1], f(!mi2)(lims)[d2])
 
         return [p1, p2, p3, p4, p5, p6]
     end
+    framepoints_front_spines = lift(limits, min1, min2, xreversed, yreversed, zreversed
+            ) do lims, mi1, mi2, xrev, yrev, zrev
+
+        rev1 = (xrev, yrev, zrev)[d1]
+        rev2 = (xrev, yrev, zrev)[d2]
+
+        mi1 = mi1 ⊻ rev1
+        mi2 = mi2 ⊻ rev2
+
+        f(mi) = mi ? minimum : maximum
+
+        p7 = dpoint(minimum(lims)[dim], f(!mi1)(lims)[d1], f(!mi2)(lims)[d2])
+        p8 = dpoint(maximum(lims)[dim], f(!mi1)(lims)[d1], f(!mi2)(lims)[d2])
+
+        return [p7, p8]
+    end
     colors = Observable{Any}()
     map!(vcat, colors, attr(:spinecolor_1), attr(:spinecolor_2), attr(:spinecolor_3))
+
     framelines = linesegments!(scene, framepoints, color = colors, linewidth = attr(:spinewidth),
         transparency = true, visible = attr(:spinesvisible), inspectable = false,
         xautolimits = false, yautolimits = false, zautolimits = false, clip_planes = Plane3f[])
 
+    front_framelines = linesegments!(scene, framepoints_front_spines, color = attr(:spinecolor_4),
+        linewidth = attr(:spinewidth),visible = map((a,b) -> a && b, ax.front_spines, attr(:spinesvisible)),
+        overdraw = true, transparency = true, inspectable = false,
+        xautolimits = false, yautolimits = false, zautolimits = false, clip_planes = Plane3f[])
+
     return gridline1, gridline2, framelines
 end
 

src/makielayout/types.jl

@@ -1798,7 +1798,15 @@ end
         "The color of y spine 3 opposite of the ticks"
         yspinecolor_3 = :black
         "The color of z spine 3 opposite of the ticks"
-        zspinecolor_3 = :black
+        zspinecolor_3 = :black       
+        "Controls if the 4. Spines are created to close the outline box"
+        front_spines = false
+        "The color of x spine 4"
+        xspinecolor_4 = :black
+        "The color of y spine 4"
+        yspinecolor_4 = :black
+        "The color of z spine 4"
+        zspinecolor_4 = :black
         "The x spine width"
         xspinewidth = 1
         "The y spine width"

src/themes/theme_black.jl

@@ -31,6 +31,9 @@ function theme_black()
             xspinecolor_3 = :white,
             yspinecolor_3 = :white,
             zspinecolor_3 = :white,
+            xspinecolor_4 = :white,
+            yspinecolor_4 = :white,
+            zspinecolor_4 = :white,
             xticklabelpad = 3,
             yticklabelpad = 3,
             zticklabelpad = 6,

src/themes/theme_minimal.jl

@@ -39,10 +39,13 @@ function theme_minimal()
             zticklabelpad = 6,
             xspinecolor_2 = :transparent,
             xspinecolor_3 = :transparent,
+            xspinecolor_4 = :transparent,
             yspinecolor_2 = :transparent,
             yspinecolor_3 = :transparent,
+            yspinecolor_4 = :transparent,
             zspinecolor_2 = :transparent,
             zspinecolor_3 = :transparent,
+            zspinecolor_4 = :transparent,
         ),
         Colorbar = (
             ticksvisible = false,