Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modification intitulés pour mieux distinguer réglementations temporaires et permanentes #1069

Merged
merged 5 commits into from
Nov 20, 2024
Merged

Modification intitulés pour mieux distinguer réglementations temporaires et permanentes #1069

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b0449ae
change form title
Lealefoulon Nov 18, 2024
115d460
points 10 & 11
Lealefoulon Nov 18, 2024
91c0d94
sup point 5
Lealefoulon Nov 18, 2024
680cbc9
Merge branch 'main' into feat/improves-type-distinction
Lealefoulon Nov 18, 2024
29e4968
Merge branch 'main' into feat/improves-type-distinction
Lealefoulon Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions translations/messages.fr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,7 +498,7 @@
</trans-unit>
<trans-unit id="regulation.general_info.identifier.help">
<source>regulation.general_info.identifier.help</source>
<target>Numéro ou nom de l'arrêté (identifiant unique)</target>
<target>Numéro de l'arrêté (identifiant unique)</target>
</trans-unit>
<trans-unit id="regulation.general_info.organization">
<source>regulation.general_info.organization</source>
Expand All @@ -518,7 +518,7 @@
</trans-unit>
<trans-unit id="regulation.general_info.description">
<source>regulation.general_info.description</source>
<target>Description</target>
<target>Intitulé</target>
Comment on lines 520 to +521
Copy link
Collaborator

@florimondmanca florimondmanca Nov 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ça introduit une différence de nommage entre le code ("description") et le langage oral qu'on utilisera ("intitulé"), ce qui n'est pas bon à moyen-long terme (principe du DDD : ubiquitous language = 1 même langage utilisé par tout le monde, + le code doit refléter la terminologie métier)

Peut-être qu'il faudrait en profiter pour renommer le champ en title, mais dans ce cas-là le faire dans une PR séparée ?

Copy link
Collaborator Author

@Lealefoulon Lealefoulon Nov 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok pour faire ça dans une PR séparée ! Donc il faudrait même changer en base de données le nom du champ dans la table c'est bien ce que tu voulais dire @florimondmanca ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oui dans l'idéal... cc @mmarchois

Ça peut aussi te faire un exercice de refacto :) (renommer un champ ça arrive)

</trans-unit>
<trans-unit id="regulation.general_info.description.help">
<source>regulation.general_info.description.help</source>
Expand Down Expand Up @@ -632,7 +632,7 @@
</trans-unit>
<trans-unit id="regulation.location.city">
<source>regulation.location.city</source>
<target>Ville ou commune</target>
<target>Ville ou code postal</target>
</trans-unit>
<trans-unit id="regulation.location.city.results_label">
<source>regulation.location.city.results_label</source>
Expand Down Expand Up @@ -802,7 +802,7 @@
</trans-unit>
<trans-unit id="regulation.locations.description">
<source>regulation.locations.description</source>
<target>Où est prévue la perturbation ?</target>
<target>Où est prévue la restriction ?</target>
</trans-unit>
<trans-unit id="regulation.measures">
<source>regulation.measures</source>
Expand Down
Loading