Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modification intitulés pour mieux distinguer réglementations temporaires et permanentes #1069

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

Lealefoulon
Copy link
Collaborator

@Lealefoulon Lealefoulon commented Nov 18, 2024

Cette PR traite simplement les changements d'intitulé

  • Points d'amélioration à traiter :
  • 1
  • 2
  • 10
  • 11

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.79%. Comparing base (bbe3e51) to head (29e4968).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1069   +/-   ##
=========================================
  Coverage     98.79%   98.79%           
  Complexity     1745     1745           
=========================================
  Files           351      351           
  Lines          7580     7580           
=========================================
  Hits           7489     7489           
  Misses           91       91           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Lealefoulon Lealefoulon marked this pull request as ready for review November 18, 2024 11:03
Comment on lines 520 to +521
<source>regulation.general_info.description</source>
<target>Description</target>
<target>Intitulé</target>
Copy link
Collaborator

@florimondmanca florimondmanca Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ça introduit une différence de nommage entre le code ("description") et le langage oral qu'on utilisera ("intitulé"), ce qui n'est pas bon à moyen-long terme (principe du DDD : ubiquitous language = 1 même langage utilisé par tout le monde, + le code doit refléter la terminologie métier)

Peut-être qu'il faudrait en profiter pour renommer le champ en title, mais dans ce cas-là le faire dans une PR séparée ?

Copy link
Collaborator Author

@Lealefoulon Lealefoulon Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok pour faire ça dans une PR séparée ! Donc il faudrait même changer en base de données le nom du champ dans la table c'est bien ce que tu voulais dire @florimondmanca ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oui dans l'idéal... cc @mmarchois

Ça peut aussi te faire un exercice de refacto :) (renommer un champ ça arrive)

@Lealefoulon Lealefoulon merged commit 62194bf into main Nov 20, 2024
6 checks passed
@Lealefoulon Lealefoulon deleted the feat/improves-type-distinction branch November 20, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants