Add Carroll Inlet as a critical passage #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the image I used to identify the name of the inlet: |
1 task
darincomeau
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Agree we want this open to avoid a land(-ice) locked ocean region - thanks @xylar !
1 task
|
My testing with this didn't work, but I found that the reason is that critical passages open up the ocean but don't change the |
1 task
|
In my testing in MPAS-Dev/compass#846, this seems to be accomplishing what we want it to. If @darincomeau agrees, I'll merge both this PR and that one, and get to work on MPAS-Dev/compass#845 |
|
Agree! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature keeps access to Carroll Inlet adjacent to Stange Ice Shelf in the Bellingshausen Sea region of Antarctica.