Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix land- and land-ice-locked cells #844

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Jul 18, 2024

We need to address land-locked and land-ice-locked cells within the process for flood-filling to ensure that the land-ice mask is connected. Otherwise, land-ice-locked cells added to the land-ice mask can create new regions of open ocean within the land ice.

Checklist

  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

We need to address land-locked and land-ice-locked cells within
the process for flood-filling to ensure that the land-ice mask
is connected.  Otherwise, land-ice-locked cells added to the
land-ice mask can create new regions of open ocean within the land
ice.
@xylar xylar added the bug Something isn't working label Jul 18, 2024
@xylar xylar requested a review from darincomeau July 18, 2024 13:35
@xylar xylar self-assigned this Jul 18, 2024
@xylar
Copy link
Collaborator Author

xylar commented Jul 18, 2024

Testing

I created a new SORRM r3 (#807) land-ice mask during the cull_mesh step with this procedure. Whereas before this fix there is a region of isolated open ocean surrounded by land or land ice near Stange Ice Shelf:
stange_orig
this is filled in with land-ice with this fix:
stange_fix

Results are in:

/lcrc/group/e3sm/ac.xylar/compass_1.4/chrysalis/test_20240718/fix_land_ice_flood_fill/ocean/global_ocean/SOwISC12to30/mesh/cull_mesh

@xylar
Copy link
Collaborator Author

xylar commented Jul 18, 2024

My actual preferred fix is to add a critical passage to keep this location (called the Carroll Inlet) open, see MPAS-Dev/geometric_features#203. But the algorithm here is behaving consistently with what we want the general solution to these kinds of issues to be.

Copy link
Collaborator

@darincomeau darincomeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't comment on the code changes but the end result is the desired one here - thanks @xylar !

@xylar
Copy link
Collaborator Author

xylar commented Jul 18, 2024

Thanks @darincomeau!

@xylar xylar merged commit 4bc61ef into MPAS-Dev:main Jul 18, 2024
4 checks passed
@xylar xylar deleted the fix-land-ice-locked-cells branch July 18, 2024 14:28
@xylar xylar added the ocean label Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ocean
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants