Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off topographic wave drag in global ocean cases #825

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

sbrus89
Copy link
Collaborator

@sbrus89 sbrus89 commented May 29, 2024

Following E3SM-Project/E3SM#6310, using config_use_topographic_wave_drag=.true. in global ocean test cases causes a segfault in the init routine for the topographic wave drag tendency, since the input streams required to calculate the wave drag coefficient are not available. Going forward, testing for this term should be restricted to barotropic tides cases.

@sbrus89 sbrus89 added bug Something isn't working ocean labels May 29, 2024
@sbrus89 sbrus89 requested review from mark-petersen and xylar May 29, 2024 20:29
@xylar xylar removed the request for review from mark-petersen May 30, 2024 09:10
@xylar
Copy link
Collaborator

xylar commented May 30, 2024

I agree, this is an easy fix. I'm testing with E3SM-Project/E3SM#6310 and this fix again to make sure I don't see failures.

@xylar
Copy link
Collaborator

xylar commented May 30, 2024

@sbrus89, I'm running into the next problem. I'm seeing large changes in the MPAS-Ocean initial condition with E3SM-Project/E3SM#6310. I'm particularly concerned about layer thickness changing by almost 50 meters. Was that expected?

temperature          Time index: 0
0:  l1: 2.27637334333235e-01  l2: 1.11516709942908e-01  linf: 8.72718501873520e-02
  ^[[91mFAIL^[[0m /lcrc/group/e3sm/ac.xylar/compass_1.4/chrysalis/test_20240530/update_e3sm_project/02_6310_6263/ocean/global_ocean/Icos240/WOA23/init/initial_state/initial_state.nc
       /lcrc/group/e3sm/ac.xylar/compass_1.4/chrysalis/test_20240530/update_e3sm_project/01_6263_current/ocean/global_ocean/Icos240/WOA23/init/initial_state/initial_state.nc
salinity             Time index: 0
0:  l1: 1.70470656169076e+00  l2: 7.73227305819931e-01  linf: 4.48482210319820e-01
  ^[[91mFAIL^[[0m /lcrc/group/e3sm/ac.xylar/compass_1.4/chrysalis/test_20240530/update_e3sm_project/02_6310_6263/ocean/global_ocean/Icos240/WOA23/init/initial_state/initial_state.nc
       /lcrc/group/e3sm/ac.xylar/compass_1.4/chrysalis/test_20240530/update_e3sm_project/01_6263_current/ocean/global_ocean/Icos240/WOA23/init/initial_state/initial_state.nc
layerThickness       Time index: 0
0:  l1: 1.89498290361250e+07  l2: 8.42600914438455e+04  linf: 4.97210844272311e+02
  ^[[91mFAIL^[[0m /lcrc/group/e3sm/ac.xylar/compass_1.4/chrysalis/test_20240530/update_e3sm_project/02_6310_6263/ocean/global_ocean/Icos240/WOA23/init/initial_state/initial_state.nc
       /lcrc/group/e3sm/ac.xylar/compass_1.4/chrysalis/test_20240530/update_e3sm_project/01_6263_current/ocean/global_ocean/Icos240/WOA23/init/initial_state/initial_state.nc
Baseline validation failed

@xylar xylar merged commit 3490abe into MPAS-Dev:main Jun 4, 2024
4 checks passed
@xylar
Copy link
Collaborator

xylar commented Jun 4, 2024

The issue above is unrelated to this PR and has been fixed in E3SM (E3SM-Project/E3SM#6454).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ocean
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants