Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update variables checked in DISMF performance test #694

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Sep 2, 2023

Needs E3SM-Project/E3SM#5910

Checklist

  • The E3SM-Project submodule has been updated with relevant E3SM changes
  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

Fixes #693

@xylar xylar added bug Something isn't working ocean E3SM PR required labels Sep 2, 2023
@xylar xylar self-assigned this Sep 2, 2023
@xylar xylar force-pushed the fix-broken-wisc-performance branch from 5f754e7 to 4c88f29 Compare September 2, 2023 12:29
@xylar
Copy link
Collaborator Author

xylar commented Sep 2, 2023

Testing

I ran the QUwISC240 performance test case from this branch twice (once as a baseline and once for comparison) and the baseline comparison now passes, whereas it failed with main and wit the current E3SM master.

@xylar
Copy link
Collaborator Author

xylar commented Sep 28, 2023

This is needed for #704. I will update the E3SM-Project submodule first to bring in E3SM-Project/E3SM#5910, which is now merged.

@xylar xylar force-pushed the fix-broken-wisc-performance branch from 4c88f29 to f977879 Compare October 2, 2023 11:56
@xylar
Copy link
Collaborator Author

xylar commented Oct 2, 2023

Failing CI should be fixed by conda-forge/mamba-feedstock#192 and an associated repopatch.

@xylar
Copy link
Collaborator Author

xylar commented Oct 2, 2023

Testing

I ran the pr test suite with this branch, comparing with a baseline from the current main. All tests passed and are BFB, including the performance tests on wISC meshes.

@xylar xylar merged commit bb61b25 into MPAS-Dev:main Oct 2, 2023
4 checks passed
@xylar xylar deleted the fix-broken-wisc-performance branch October 2, 2023 15:16
@xylar xylar mentioned this pull request Oct 4, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working E3SM PR finished ocean
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expected variables not being written out in global ocean performance tests with ice-shelf cavities
1 participant