Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update E3SM-Project submodule #708

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Sep 28, 2023

This merge updates the E3SM-Project submodule from 86f7e8b to 894b5b2.

This update includes the following MPAS-Ocean and MPAS-Frameworks PRs (check mark indicates bit-for-bit with previous PR in the list):

@xylar xylar added in progress This PR is not ready for review or merging E3SM PR finished labels Sep 28, 2023
@xylar xylar self-assigned this Sep 28, 2023
@xylar
Copy link
Collaborator Author

xylar commented Sep 28, 2023

I'm seeing large, non-bit-for-bit changes between E3SM-Project/E3SM#5857 and E3SM-Project/E3SM#5910. I need to find out why, since neither of these PRs explains the changes.

@xylar xylar removed the in progress This PR is not ready for review or merging label Sep 28, 2023
@xylar xylar marked this pull request as ready for review September 28, 2023 20:23
@xylar
Copy link
Collaborator Author

xylar commented Sep 28, 2023

The non BFB changes mentioned above were from E3SM-Project/E3SM#5892 and are expected because that PR fixed the submesoscale parameterization for standalone runs.

All non-BFB changes are accounted for so it seems safe (and like a very good idea) to advance the submodule.

@xylar
Copy link
Collaborator Author

xylar commented Sep 28, 2023

I'm holding off on this until I can finish making mesh files for #706, which is in progress. That PR uses the MPAS-Ocean build in my main branch, so I don't want to update it with non-BFB changes (especially accidentally) until that's done.

@xylar xylar merged commit a1bf71c into MPAS-Dev:main Oct 2, 2023
4 checks passed
@xylar xylar deleted the update-e3sm-project branch October 2, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant