-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bathymetry remapping #566
Conversation
fb0be0a
to
c5c4ad4
Compare
141207a
to
4500ec6
Compare
If no remapped topogrpahy step is provided, the coastline comes from the coastline from geometric_features as before
QU240 and Icos240 meshes don't include this step.
This should work even on machines with fewer cores per node now.
4500ec6
to
6d29150
Compare
@milenaveneziani, is this something you are willing to review? Who else would you suggest I ask? |
74e8eea
to
ae6986a
Compare
Thanks @xylar. What do you think would be the best way to review this? |
@milenaveneziani, that's a good question. I wasn't thinking of a code review, just looking at the initial condition. Maybe the place to start is to look at |
Sounds good. I'll do that. |
@xylar: I looked at the 3 bathymetry fields in paraview, paying particular attention to the SO shelves, Arctic and Canadian Archipelago, Florida St and Indonesia Throughflow region. I do not see anything strange. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved based on visual inspection of bottomDepth
for the 3 meshes.
Thanks so much, @milenaveneziani! |
This merge adds a step for remapping bathymetry and ice-shelf topography to the ocean framework. It also adds this step to the mesh test cases in
global_ocean
. It updates thecull_mesh
step to use the remapped bathymetry to determine the land mask if topography remapping was performed. It updates most meshes to use the this new approach, leaving the QU240 and Icos240 meshes as they were for more efficient testing. Finally, this merge modifies the topography output with the variable names expected in MPAS-Ocean init mode and creates a stream for reading them in.An alteration is needed to MPAS-Ocean to bypass reading in the land-ice topography from a lon-lat file. Such a bypass exists for the bathymetry but not for land-ice topography.
Needs: E3SM-Project/E3SM#5553
Checklist
api.rst
) has any new or modified class, method and/or functions listedE3SM-Project
submodule has been updated with relevant E3SM changes - merged in Update E3SM-Project submodule #585Testing
in this PR) any testing that was used to verify the changes