Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bathymetry remapping #566

Merged
merged 7 commits into from
Apr 5, 2023
Merged

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Mar 16, 2023

This merge adds a step for remapping bathymetry and ice-shelf topography to the ocean framework. It also adds this step to the mesh test cases in global_ocean. It updates the cull_mesh step to use the remapped bathymetry to determine the land mask if topography remapping was performed. It updates most meshes to use the this new approach, leaving the QU240 and Icos240 meshes as they were for more efficient testing. Finally, this merge modifies the topography output with the variable names expected in MPAS-Ocean init mode and creates a stream for reading them in.

An alteration is needed to MPAS-Ocean to bypass reading in the land-ice topography from a lon-lat file. Such a bypass exists for the bathymetry but not for land-ice topography.

Needs: E3SM-Project/E3SM#5553

Checklist

  • User's Guide has been updated
  • Developer's Guide has been updated
  • API documentation in the Developer's Guide (api.rst) has any new or modified class, method and/or functions listed
  • Documentation has been built locally and changes look as expected
  • The E3SM-Project submodule has been updated with relevant E3SM changes - merged in Update E3SM-Project submodule #585
  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

@xylar xylar added enhancement New feature or request ocean in progress This PR is not ready for review or merging E3SM PR required labels Mar 16, 2023
@xylar xylar force-pushed the add_bathymetry_remapping branch 12 times, most recently from fb0be0a to c5c4ad4 Compare March 23, 2023 14:15
@xylar xylar self-assigned this Mar 29, 2023
@xylar xylar force-pushed the add_bathymetry_remapping branch from 141207a to 4500ec6 Compare March 29, 2023 12:46
xylar added 5 commits April 2, 2023 21:06
If no remapped topogrpahy step is provided, the coastline comes
from the coastline from geometric_features as before
QU240 and Icos240 meshes don't include this step.
This should work even on machines with fewer cores per node now.
@xylar xylar force-pushed the add_bathymetry_remapping branch from 4500ec6 to 6d29150 Compare April 2, 2023 19:08
@xylar
Copy link
Collaborator Author

xylar commented Apr 3, 2023

Testing

I ran the ECwISC30to60, SOwISC12to60 and WCwISC14 meshes through mesh, init and performance_test test cases with this branch:

/lcrc/group/e3sm/ac.xylar/compass_1.2/chrysalis/test_20230402/remap_bathy

All 3 completed successfully.

The initial condition are in:

/lcrc/group/e3sm/ac.xylar/compass_1.2/chrysalis/test_20230402/remap_bathy/ecwisc/ocean/global_ocean/ECwISC30to60/PHC/init/initial_state/
/lcrc/group/e3sm/ac.xylar/compass_1.2/chrysalis/test_20230402/remap_bathy/sowisc/ocean/global_ocean/SOwISC12to60/PHC/init/initial_state/
/lcrc/group/e3sm/ac.xylar/compass_1.2/chrysalis/test_20230402/remap_bathy/wcwisc/ocean/global_ocean/WCwISC14/PHC/init/initial_state/

Here are 2 screenshots of the bathymetry (bottomDepth) from the SORRM mesh, first in the high-res region:
weddell

Then, in the low res region:
north_atlantic

@xylar xylar removed the in progress This PR is not ready for review or merging label Apr 3, 2023
@xylar
Copy link
Collaborator Author

xylar commented Apr 3, 2023

@milenaveneziani, is this something you are willing to review? Who else would you suggest I ask?

@xylar xylar requested a review from milenaveneziani April 3, 2023 09:20
@xylar xylar force-pushed the add_bathymetry_remapping branch from 74e8eea to ae6986a Compare April 3, 2023 13:07
@milenaveneziani
Copy link

Thanks @xylar. What do you think would be the best way to review this?

@xylar
Copy link
Collaborator Author

xylar commented Apr 4, 2023

@milenaveneziani, that's a good question. I wasn't thinking of a code review, just looking at the initial condition. Maybe the place to start is to look at bottomDepth in ParaView as I did, though I realize this isn't very quantitative. I think we're only going to notice dynamical problems when we run simulations so I guess what I was hoping for is that you might check for weird issues like you had spotted in the Chukchi Sea in the previous bathymetry.

@milenaveneziani
Copy link

Sounds good. I'll do that.

@milenaveneziani
Copy link

@xylar: I looked at the 3 bathymetry fields in paraview, paying particular attention to the SO shelves, Arctic and Canadian Archipelago, Florida St and Indonesia Throughflow region. I do not see anything strange.
I even learned about the Aleutian Trench: I was wondering why the bathymetry would become suddenly so deep just south of the Aleutian Islands, and indeed there is a trench arch there!

Copy link

@milenaveneziani milenaveneziani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on visual inspection of bottomDepth for the 3 meshes.

@xylar
Copy link
Collaborator Author

xylar commented Apr 5, 2023

Thanks so much, @milenaveneziani!

@xylar xylar merged commit f7d0d2c into MPAS-Dev:main Apr 5, 2023
@xylar xylar deleted the add_bathymetry_remapping branch April 5, 2023 16:31
@xylar xylar mentioned this pull request May 13, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants