Renormalize topography after remapping in global_ocean
#640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestingI ran the ECwISC mesh through |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug in #566 left the remapped topography multiplied by the remapped ocean mask. This means that the topography falls back to zero at coastlines and grounding lines under ice shelves. This merge fixes that issue by renormalizing topography as long as the remapped ocean mask is over a given threshold (0.01 by default).
This merge also turns off smoothing of topography in
global_oceaninit mode because it should no longer be needed with the conservative remapping approach.Checklist
Testingin this PR) any testing that was used to verify the changes