Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glTFへシリアライズするためのモジュールを作成 #16

Merged
merged 65 commits into from
Dec 7, 2023
Merged

glTFへシリアライズするためのモジュールを作成 #16

merged 65 commits into from
Dec 7, 2023

Conversation

nokonoko1203
Copy link
Collaborator

@nokonoko1203 nokonoko1203 commented Nov 17, 2023 •
edited
Loading

glTF仕様（https://registry.khronos.org/glTF/specs/2.0/glTF-2.0.html#properties-reference ）に従って、モデルをnusamai-gltf/src/modelsに定義しました。

nusamai-gltf/examples/geometry_to_gltf.rsにモデルの利用方法を含めた、glTF（glb）への変換方法を書いています。

以下のコマンドを実行

cargo run --example geometry_to_gltf --release -- ~/path/to/22203_numazu-shi_2021_citygml_4_op/udx/bldg/52385628_*_6697_op.gml

@nokonoko1203 nokonoko1203 marked this pull request as draft November 17, 2023 09:15
@codecov Codecov
Copy link

codecov bot commented Nov 22, 2023 •
edited
Loading

Codecov Report

Attention: 48 lines in your changes are missing coverage. Please review.

Files Patch % Lines
nusamai-gltf/src/models/mesh.rs 38.88% 11 Missing ⚠️
nusamai-gltf/src/models/buffer.rs 30.00% 7 Missing ⚠️
nusamai-gltf/src/models/gltf.rs 25.00% 6 Missing ⚠️
nusamai-gltf/src/models/asset.rs 28.57% 5 Missing ⚠️
nusamai-gltf/src/models/node.rs 28.57% 5 Missing ⚠️
nusamai-gltf/src/models/scene.rs 16.66% 5 Missing ⚠️
nusamai-gltf/src/models/accessor.rs 63.63% 4 Missing ⚠️
nusamai-gltf/src/models/animation.rs 90.00% 1 Missing ⚠️
nusamai-gltf/src/models/camera.rs 80.00% 1 Missing ⚠️
nusamai-gltf/src/models/image.rs 66.66% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
Components Coverage Δ
tauri-app 0.00% <ø> (ø)
nusamai-* 63.25% <65.46%> (+0.14%) ⬆️

📢 Thoughts on this report? Let us know!

@nokonoko1203 nokonoko1203 marked this pull request as ready for review December 6, 2023 04:59
@sorami sorami mentioned this pull request Dec 6, 2023
Closed
@nokonoko1203 nokonoko1203 mentioned this pull request Dec 6, 2023
Closed
ciscorn
ciscorn approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@ciscorn ciscorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
くまなく見ているわけではないのと、examplesまわりはまったく見てないですが、皆で直していく前提で一旦マージしましょうか。

@nokonoko1203
Copy link
Collaborator Author

ありがとうございます！
マージします！

@nokonoko1203 nokonoko1203 merged commit 0873217 into main Dec 7, 2023
3 checks passed
@nokonoko1203 nokonoko1203 deleted the feature/gltf branch December 7, 2023 02:42
ciscorn pushed a commit that referenced this pull request Dec 27, 2023
@nokonoko1203 @ciscorn
glTFへシリアライズするためのモジュールを作成 (#16)
28368e9 
glTF仕様（https://registry.khronos.org/glTF/specs/2.0/glTF-2.0.html#properties-reference
）に従って、モデルを`nusamai-gltf/src/models`に定義しました。


`nusamai-gltf/examples/geometry_to_gltf.rs`にモデルの利用方法を含めた、glTF（glb）への変換方法を書いています。

以下のコマンドを実行
```bash
cargo run --example geometry_to_gltf --release -- ~/path/to/22203_numazu-shi_2021_citygml_4_op/udx/bldg/52385628_*_6697_op.gml 
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciscorn ciscorn ciscorn approved these changes

@sorami sorami Awaiting requested review from sorami

@xinmiaooo xinmiaooo Awaiting requested review from xinmiaooo

Assignees

@nokonoko1203 nokonoko1203

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nokonoko1203 @ciscorn