Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

including install space node, timeout for initial pose, and covariance defaults / configurable #11

Open
wants to merge 7 commits into
base: ros2
Choose a base branch
from

Conversation

SteveMacenski
Copy link

Adding node install space for people that use the install space rather than devel space for deploying.

@SteveMacenski
Copy link
Author

SteveMacenski commented Sep 26, 2017

I also added a timeout for the number of attempts parameterized in the launch file to get the initial pose before just using a relative measurement in response to my own desire and #8

@SteveMacenski SteveMacenski changed the title including install space node including install space node, timeout for initial pose Sep 26, 2017
@SteveMacenski
Copy link
Author

finally, adding in reasonable covariance defaults in the message

@SteveMacenski SteveMacenski changed the title including install space node, timeout for initial pose including install space node, timeout for initial pose, and covariance defaults Sep 26, 2017
@SteveMacenski SteveMacenski changed the title including install space node, timeout for initial pose, and covariance defaults including install space node, timeout for initial pose, and covariance defaults, correcting frames Sep 26, 2017
@SteveMacenski SteveMacenski changed the title including install space node, timeout for initial pose, and covariance defaults, correcting frames including install space node, timeout for initial pose, and covariance defaults / configurable Sep 27, 2017
@lianshangni0922
Copy link

I think it should be changed like this :
initial_robot_pose.pose.pose.position.x = 0;
initial_robot_pose.pose.pose.position.y = 0;
initial_robot_pose.pose.pose.position.z = 0;
initial_robot_pose.pose.pose.orientation.w = 0;
initial_robot_pose.pose.pose.orientation.x = 0;
initial_robot_pose.pose.pose.orientation.y = 0;
initial_robot_pose.pose.pose.orientation.z = 1;

@SteveMacenski
Copy link
Author

That's true, but this PR has been dead for while anyhow. Not sure anyone is going to merge it but it implements the covariance variables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants