Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sample geodataframe notebook with readme notes #113

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

emmalu
Copy link
Collaborator

@emmalu emmalu commented Sep 15, 2023

Summary:

What did I do?
Created a sample notebook that covers how to leverage data from a Pandas Geodataframe as a GeoData layer within stac_ipyleaflet.

Why *** did I do it? (What was the motivation?)

  • To help users extend current stac_ipyleaflet functionality.

How *** can someone test or demo my changes?

  • Follow the notebook!
Screenshot 2023-09-15 at 1 17 58 PM

Fixes or Addresses Issue #: #85

Checklist before requesting a review:

  • My code follows the guidelines of this project
  • I performed a self-review of my code changes
  • I have added my changes to the change log (HISTORY.rst)
  • I have completed spell-checking, removed unnecessary print statements & commented-out code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@chuckwondo
Copy link

This is a very minor comment, but perhaps you should consider renaming the class StacIpyleaflet to StacMap. This might aid in clarity as to what it is.

Consider that when using iplyleaflet, this is conventional:

from ipyleaflet import Map

m = Map()

or

import ipyleaflet

m = ipyleaflet.Map()

Since StacIpyleaflet is a subclass of Map (ipyleaflet.Map), it might aid clarity by naming StacIpyleaflet to StacMap so that it better corresponds to the iplyleaflet conventions. This would then give you this:

from stac_ipyleaflet import StacMap

m = StacMap()

or

import stac_ipyleaflet

m = stac_ipyleaflet.StacMap()

It seems a bit odd to do the following, not only because of the redundancy, but also because it isn't obvious that StacIpyleaflet is an ipyleaflet.Map:

from stac_ipyleaflet import StacIpyleaflet

Anyway, just my 2 cents.

@emmalu
Copy link
Collaborator Author

emmalu commented Sep 19, 2023

Anyway, just my 2 cents.

Thanks for your feedback, @chuckwondo - I created a new issue around this.

@emmalu emmalu merged commit 2aeda1b into main Sep 19, 2023
@wildintellect wildintellect deleted the docs/add-geodataframe-sample-nb branch September 27, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants