You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a very minor comment, but perhaps you should consider renaming the class `StacIpyleaflet` to `StacMap`. This might aid in clarity as to what it is.
Consider that when using iplyleaflet, this is conventional:
fromipyleafletimportMapm=Map()
or
importipyleafletm=ipyleaflet.Map()
Since StacIpyleaflet is a subclass of Map (ipyleaflet.Map), it might aid clarity by naming StacIpyleaflet to StacMap so that it better corresponds to the iplyleaflet conventions. This would then give you this:
fromstac_ipyleafletimportStacMapm=StacMap()
or
importstac_ipyleafletm=stac_ipyleaflet.StacMap()
It seems a bit odd to do the following, not only because of the redundancy, but also because it isn't obvious that StacIpyleaflet is an ipyleaflet.Map:
Consider that when using
iplyleaflet
, this is conventional:or
Since
StacIpyleaflet
is a subclass ofMap
(ipyleaflet.Map
), it might aid clarity by namingStacIpyleaflet
toStacMap
so that it better corresponds to theiplyleaflet
conventions. This would then give you this:or
It seems a bit odd to do the following, not only because of the redundancy, but also because it isn't obvious that
StacIpyleaflet
is anipyleaflet.Map
:Anyway, just my 2 cents.
Originally posted by @chuckwondo in #113 (comment)
The text was updated successfully, but these errors were encountered: