Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Map instance naming system #114

Open
emmalu opened this issue Sep 19, 2023 · 0 comments
Open

Refactor Map instance naming system #114

emmalu opened this issue Sep 19, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@emmalu
Copy link
Collaborator

emmalu commented Sep 19, 2023

          This is a very minor comment, but perhaps you should consider renaming the class `StacIpyleaflet` to `StacMap`. This might aid in clarity as to what it is.

Consider that when using iplyleaflet, this is conventional:

from ipyleaflet import Map

m = Map()

or

import ipyleaflet

m = ipyleaflet.Map()

Since StacIpyleaflet is a subclass of Map (ipyleaflet.Map), it might aid clarity by naming StacIpyleaflet to StacMap so that it better corresponds to the iplyleaflet conventions. This would then give you this:

from stac_ipyleaflet import StacMap

m = StacMap()

or

import stac_ipyleaflet

m = stac_ipyleaflet.StacMap()

It seems a bit odd to do the following, not only because of the redundancy, but also because it isn't obvious that StacIpyleaflet is an ipyleaflet.Map:

from stac_ipyleaflet import StacIpyleaflet

Anyway, just my 2 cents.

Originally posted by @chuckwondo in #113 (comment)

@emmalu emmalu added the enhancement New feature or request label Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant