Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: frontend boilerplate #9

Merged
merged 12 commits into from
Nov 15, 2023
Merged
Show file tree
Hide file tree
Changes from 11 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .env.example
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,13 @@ PUSHER_SCHEME=https
PUSHER_APP_CLUSTER=mt1

VITE_APP_NAME="${APP_NAME}"
VITE_APP_ENV="${APP_ENV}"
VITE_APP_URL="${APP_URL}"
VITE_API_URL="${APP_URL}"
VITE_GOOGLE_AUTH_SSO_CLIENT_ID=""

VITE_PUSHER_APP_KEY="${PUSHER_APP_KEY}"
VITE_PUSHER_HOST="${PUSHER_HOST}"
VITE_PUSHER_PORT="${PUSHER_PORT}"
VITE_PUSHER_SCHEME="${PUSHER_SCHEME}"
VITE_PUSHER_APP_CLUSTER="${PUSHER_APP_CLUSTER}"
VITE_PUSHER_APP_CLUSTER="${PUSHER_APP_CLUSTER}"
7 changes: 1 addition & 6 deletions .eslintrc.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,7 @@ const config = {
],
"import/consistent-type-specifier-style": ["error", "prefer-top-level"],
},
ignorePatterns: [
"**/.eslintrc.cjs",
"**/*.config.js",
"**/*.config.cjs",
"resources/js/app.js",
],
ignorePatterns: ["**/.eslintrc.cjs", "**/*.config.js", "**/*.config.cjs"],
reportUnusedDisableDirectives: true,
globals: {
React: "writable",
Expand Down
55 changes: 40 additions & 15 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,35 +1,60 @@
# Light It Pull Request Template ⚡⚡
# ⚡ TaskTitle - [###](https://app.clickup.com/t/###)

_Resolve_: [closes -#](https://app.clickup.com/t/ticket_id)
## 💻 What type of change is this?

## Description and Requires ⭐
- [ ] 💎 Feature
- [ ] 🐛 Bug Fix
- [ ] 📝 Documentation Update
- [ ] 🎨 Styling
- [ ] 🧑‍💻 Code Refactor
- [ ] 🔥 Performance Improvements
- [ ] ✅ Test
- [ ] 🤖 Build / CI

## ⭐ Description

<!--
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Example:
-->

Ex. I've added support for authentication to implement Key Result 2 of OKR1. It includes
model, table, controller and test. For more background, see ticket #CU-834794.
I've added support for authentication to implement Key Result 2 of OKR1. It includes model, table, controller and test.

<!--
ONLY ADD SECTION IF A NEW PACKAGE IS ADDED
### Requires
This pr requires the following packages to be installed:
- `package1`
- `package2`
The packages are used for `reason1` and `reason2`.

Because of this, you must run `npm i` before starting.
-->

## 📷 Screenshots

- [ ] This change requires a database update or migration
- [ ] This change requires a documentation update
<!--
Please include before AND after screenshots of the change.
-->

## Proof of Test (optional) 📷
### Before

Include Screenshots if is necessary.
### After

### How Has This Been Tested? ❓
## 💬 Comments

<!--
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Please describe any known issues, bugs, or unintended consequences with this change. Also, please include any additional comments you feel are relevant to the reviewer.
-->

- [ ] Test A
- [ ] Test B
This pr is blocked by #1234.
Im awaiting backend changes to be merged before I can complete this, etc.
This

## Checklist ✅
## ✅ Checklist

- [ ] This PR can be merged (it is not a draft, work in progress, or blocked on another PR)
- [ ] I have tested this change locally in multiple screen sizes
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have made corresponding changes to the documentation
Expand Down
2 changes: 2 additions & 0 deletions cspell.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
"autoload",
"Autoloaded",
"autoloading",
"axios",
"Barryvdh",
"beanstalkd",
"captainhook",
Expand All @@ -22,6 +23,7 @@
"docblocks",
"EHLO",
"Encrypter",
"env",
"fieldsets",
"filesize",
"Flugg",
Expand Down
Loading