update: frontend boilerplate #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sojeda
reviewed
Nov 13, 2023
JLin-99
commented
Nov 13, 2023
ddoumecq
reviewed
Nov 14, 2023
package.json
Outdated
| @@ -3,17 +3,22 @@ | |||
| "scripts": { | |||
| "dev": "vite", | |||
| "build": "vite build", | |||
| "format": "prettier --check \"./resources/js/**/*.{js,cjs,mjs,ts,tsx,md,json}\" --ignore-path ../../.gitignore", | |||
| "format": "prettier --write \"./resources/js/**/*.{js,cjs,mjs,ts,tsx,md,json}\" --ignore-path ../../.gitignore", | |||
There was a problem hiding this comment.
the normal format script should be just --check because it's being called in the github actions and we DON'T want top modify our code there, only locally. Please add a different script that does the --write just so we are sure we are calling it only ever by hand
There was a problem hiding this comment.
sorry I forgot to remove it I was trying the --write option because my local prettier went crazy haha. That being said, should I make another script that does the --write or just put it back as it was before?
ddoumecq
approved these changes
Nov 15, 2023
sojeda
pushed a commit
that referenced
this pull request
Nov 28, 2023
* chore: app file rename * chore: app file rename * feat: frontend environment variables * feat: update env.example * feat: axios instances * feat: authentication * feat: add examples * feat: update PR template * fix: prettier * fix: overflow scroll * fix: .github/PULL_REQUEST_TEMPLATE.md * feat: add format options
sojeda
pushed a commit
that referenced
this pull request
Jan 2, 2024
* chore: app file rename * chore: app file rename * feat: frontend environment variables * feat: update env.example * feat: axios instances * feat: authentication * feat: add examples * feat: update PR template * fix: prettier * fix: overflow scroll * fix: .github/PULL_REQUEST_TEMPLATE.md * feat: add format options
sojeda
pushed a commit
that referenced
this pull request
Jan 2, 2024
* chore: app file rename * chore: app file rename * feat: frontend environment variables * feat: update env.example * feat: axios instances * feat: authentication * feat: add examples * feat: update PR template * fix: prettier * fix: overflow scroll * fix: .github/PULL_REQUEST_TEMPLATE.md * feat: add format options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚡ Frontend Boilerplate - ### ⚡
💻 What type of change is this?
⭐ Description
I've updated the
resourcefolder.📷 Screenshots
✅ Checklist