[RELEASE] 23 April 2024 🚀🚀 #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: inova flow * chore: update faqs
* feat: send email when someone subscribes to EO * fix: implementing improvements
…128) * feat: add in the footer the legal disclaimers * feat: add disclaimer only for Cancer Support Community * review: implement changes from code-review
| success: boolean; | ||
| } | ||
|
|
||
| export const subscribeToEoEmailPost = async (email: string) => { |
There was a problem hiding this comment.
post word is unnecessary
Comment on lines
+12
to
+15
| mutationFn: subscribeToEoEmailPost, | ||
| onSuccess: () => setSubmitted(true), | ||
| onError: () => toast.error("Something went wrong, try again.") | ||
| }); |
There was a problem hiding this comment.
Should we validate the email has the correct format?
| @@ -81,9 +110,18 @@ export function Footer({ flow }: FooterProps) { | |||
| > | |||
| Wise use for all. | |||
| </Typography> | |||
| <Typography className="font-new-hero font-normal text-[#ababab]"> | |||
| <Typography className="mb-[36px] font-new-hero text-[14px] font-normal text-[#ababab]"> | |||
There was a problem hiding this comment.
Suggested change
| <Typography className="mb-[36px] font-new-hero text-[14px] font-normal text-[#ababab]"> | |
| <Typography className="mb-9 font-new-hero text-[14px] font-normal text-[#ababab]"> |
| @@ -89,7 +89,7 @@ export const CancerSurveyThankYou = () => { | |||
| </AllDonePanel> | |||
| <HowEOWorks pilot={flow === Flows.cancer_pilot} /> | |||
| <FAQs channel="cancer" flow={flow} /> | |||
| {['c_org', 'cancer_pilot', 'twist_out_cancer', 'cancer_support_community', 'employer_center', 'resource_center_1', 'resource_center_2'].includes(flow) | |||
| {['c_org', 'cancer_pilot', 'twist_out_cancer', 'cancer_support_community', 'employer_center', 'resource_center_1', 'resource_center_2', 'inova'].includes(flow) | |||
There was a problem hiding this comment.
Avoid the magic strings, lets move these options to a const or a config file.
Comment on lines
+93
to
+102
| {[ | ||
| "c_org", | ||
| "cancer_pilot", | ||
| "twist_out_cancer", | ||
| "cancer_support_community", | ||
| "employer_center", | ||
| "resource_center_1", | ||
| "resource_center_2", | ||
| "inova", | ||
| ].includes(flow) ? ( |
lucaslightit
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.