Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 (pr): Update PR CI workflow to include typechecks [no-issue] #25

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

valpinkman
Copy link
Member

@valpinkman valpinkman commented Feb 14, 2024

📝 Description

Adds a typecheck script to packages
Updates the CI with it
Also limits the number of runners to 1 instead of 4 of them, the CI takes about ~1m30 so I don't think we need to split those test for the moment.

❓ Context

  • JIRA or GitHub link: [NO-ISSUE]

✅ Checklist

Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.

  • Covered by automatic tests.
  • Impact of the changes:
    • Adds a new check during PR checks
    • Adds a new typecheck script
    • Limit runners to 1

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.

Copy link

vercel bot commented Feb 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
device-sdk-ts-sample ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2024 3:31pm

@valpinkman valpinkman changed the title 👷 (pr): Update PR CI workflow to include typechecks 👷 (pr): Update PR CI workflow to include typechecks [no-issue] Feb 14, 2024
@valpinkman valpinkman merged commit 29278f9 into develop Feb 14, 2024
3 checks passed
@valpinkman valpinkman deleted the chore/update-ci branch February 14, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants