Skip to content

Commit

Permalink
👷 (pr): Update PR CI workflow to include typechecks
Browse files Browse the repository at this point in the history
  • Loading branch information
valpinkman committed Feb 14, 2024
1 parent 595958e commit 0717aea
Show file tree
Hide file tree
Showing 8 changed files with 17 additions and 25 deletions.
31 changes: 7 additions & 24 deletions .github/workflows/pull_request.yml
Original file line number Diff line number Diff line change
@@ -1,42 +1,25 @@
name: pull_request
on: [pull_request]

env:
FORCE_COLOR: "1"

jobs:
lint:
health-check:
runs-on: [device-sdk-4xlarge-linux]
env:
CI_JOB_NUMBER: 1
steps:
- uses: actions/checkout@v3

- uses: ./actions/setup-toolchain-composite

- name: Lint
env:
FORCE_COLOR: "1"
run: pnpm lint

prettier:
runs-on: [device-sdk-4xlarge-linux]
env:
CI_JOB_NUMBER: 1
steps:
- uses: actions/checkout@v3

- uses: ./actions/setup-toolchain-composite

- name: Prettier
run: pnpm prettier

test:
runs-on: [device-sdk-4xlarge-linux]
env:
CI_JOB_NUMBER: 1
steps:
- uses: actions/checkout@v3

- uses: ./actions/setup-toolchain-composite
- name: Typecheck
run: pnpm typecheck

- name: Test
env:
FORCE_COLOR: "1"
run: pnpm test
3 changes: 2 additions & 1 deletion apps/sample/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
"lint": "next lint --max-warnings=0",
"lint:fix": "next lint --fix",
"prettier": "prettier . --check",
"prettier:fix": "prettier . --write"
"prettier:fix": "prettier . --write",
"typecheck": "tsc --noEmit"
},
"dependencies": {
"@ledgerhq/device-sdk-core": "workspace:*",
Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
"prettier": "turbo run prettier --log-order=grouped",
"prettier:fix": "turbo run prettier:fix --log-order=grouped",
"test": "turbo run test --log-order=grouped",
"typecheck": "turbo run typecheck --log-order=grouped",
"core": "pnpm --filter @ledgerhq/device-sdk-core",
"signer": "pnpm --filter @ledgerhq/device-sdk-signer",
"trusted-apps": "pnpm --filter @ledgerhq/device-sdk-trusted-apps",
Expand Down
1 change: 1 addition & 0 deletions packages/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
"test": "jest src",
"test:watch": "pnpm test -- --watch",
"test:coverage": "pnpm test -- --coverage",
"typecheck": "tsc --noEmit",
"module:create": "pnpm hygen core-module with-prompt"
},
"dependencies": {
Expand Down
1 change: 1 addition & 0 deletions packages/signer/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
"lint:fix": "eslint --cache --fix --ext .ts \"src\"",
"prettier": "prettier . --check",
"prettier:fix": "prettier . --write",
"typecheck": "tsc --noEmit",
"test": "jest --passWithNoTests"
},
"dependencies": {
Expand Down
1 change: 1 addition & 0 deletions packages/trusted-apps/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
"lint:fix": "eslint --cache --fix --ext .ts \"src\"",
"prettier": "prettier . --check",
"prettier:fix": "prettier . --write",
"typecheck": "tsc --noEmit",
"dev": "tsc --watch",
"test": "jest --passWithNoTests"
},
Expand Down
1 change: 1 addition & 0 deletions packages/ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
"lint:fix": "eslint --cache --fix --ext .ts \"src\"",
"prettier": "prettier . --check",
"prettier:fix": "prettier . --write",
"typecheck": "tsc --noEmit",
"test": "jest --passWithNoTests"
},
"dependencies": {
Expand Down
3 changes: 3 additions & 0 deletions turbo.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@
"dependsOn": ["build", "lint"],
"outputs": [],
"inputs": ["src/**/*.ts", "tests/**/*.ts"]
},
"typecheck": {
"dependsOn": ["^typecheck"]
}
}
}

0 comments on commit 0717aea

Please sign in to comment.