[DSDK-196][FEAT][OTHR] Add prettier configuration

.github/workflows/pull_request.yml

@@ -13,6 +13,18 @@ jobs:
       - name: Lint
         run: pnpm lint
 
+  prettier:
+    runs-on: [device-sdk-4xlarge-linux]
+    env:
+      CI_JOB_NUMBER: 1
+    steps:
+      - uses: actions/checkout@v3
+
+      - uses: ./actions/setup-toolchain-composite
+
+      - name: Prettier
+        run: pnpm prettier
+
   test:
     runs-on: [device-sdk-4xlarge-linux]
     env:

apps/sample/.prettierrc.js

@@ -0,0 +1,3 @@
+module.exports = {
+  ...require("@ledgerhq/prettier-config-dsdk"),
+};

apps/sample/package.json

@@ -7,7 +7,9 @@
     "build": "next build",
     "start": "next start",
     "lint": "next lint --max-warnings=0",
-    "lint:fix": "next lint --fix"
+    "lint:fix": "next lint --fix",
+    "prettier": "prettier . --check",
+    "prettier:fix": "prettier . --write"
   },
   "dependencies": {
     "@ledgerhq/device-sdk-core": "workspace:*",
@@ -19,6 +21,7 @@
   },
   "devDependencies": {
     "@ledgerhq/eslint-config-dsdk": "workspace:*",
+    "@ledgerhq/prettier-config-dsdk": "workspace:*",
     "@ledgerhq/tsconfig-dsdk": "workspace:*",
     "@types/react": "^18",
     "@types/styled-components": "^5.1.25",

apps/sample/src/providers/DeviceSdkProvider/index.tsx

@@ -1,5 +1,5 @@
 import { createContext, useContext } from "react";
-import { DeviceSdk,DeviceSdkBuilder } from "@ledgerhq/device-sdk-core";
+import { DeviceSdk, DeviceSdkBuilder } from "@ledgerhq/device-sdk-core";
 
 export const sdk = new DeviceSdkBuilder().build();
 

apps/sample/tsconfig.json

@@ -7,18 +7,10 @@
       }
     ],
     "paths": {
-      "@/*": [
-        "./src/*"
-      ]
+      "@/*": ["./src/*"]
     },
     "strictNullChecks": true
   },
-  "include": [
-    "**/*.ts",
-    "**/*.tsx",
-    ".next/types/**/*.ts"
-  ],
-  "exclude": [
-    "node_modules"
-  ]
+  "include": ["**/*.ts", "**/*.tsx", ".next/types/**/*.ts"],
+  "exclude": ["node_modules"]
 }

package.json

@@ -12,6 +12,8 @@
     "dev": "turbo dev --log-order=grouped",
     "lint": "turbo run lint --log-order=grouped",
     "lint:fix": "turbo run lint:fix --log-order=grouped",
+    "prettier": "turbo run prettier --log-order=grouped",
+    "prettier:fix": "turbo run prettier:fix --log-order=grouped",
     "test": "turbo run test --log-order=grouped",
     "core": "pnpm --filter @ledgerhq/device-sdk-core",
     "signer": "pnpm --filter @ledgerhq/device-sdk-signer",

packages/config/prettier/index.js

@@ -0,0 +1,6 @@
+/** @type {import('prettier').Config} **/
+module.exports = {
+  tabWidth: 2,
+  semi: true,
+  singleQuote: false,
+};

packages/config/prettier/package.json

@@ -0,0 +1,12 @@
+{
+  "name": "@ledgerhq/prettier-config-dsdk",
+  "license": "MIT",
+  "version": "0.0.1",
+  "private": true,
+  "files": [
+    "index.js"
+  ],
+  "devDependencies": {
+    "prettier": "^3.1.1"
+  }
+}

packages/core/.prettierignore

@@ -0,0 +1 @@
+lib/*

packages/core/.prettierrc.js

@@ -0,0 +1,3 @@
+module.exports = {
+  ...require("@ledgerhq/prettier-config-dsdk"),
+};

packages/core/package.json

@@ -12,6 +12,8 @@
     "dev": "tsc && (concurrently \"tsc -w -p tsconfig.prod.json\" \"tsc-alias -w -p tsconfig.prod.json\")",
     "lint": "eslint --cache --ext .ts \"src\" --max-warnings=0",
     "lint:fix": "eslint --cache --fix --ext .ts \"src\"",
+    "prettier": "prettier . --check",
+    "prettier:fix": "prettier . --write",
     "test": "jest src",
     "test:watch": "pnpm test -- --watch",
     "test:coverage": "pnpm test -- --coverage",
@@ -27,6 +29,7 @@
     "@ledgerhq/eslint-config-dsdk": "workspace:*",
     "@ledgerhq/jest-config-dsdk": "workspace:*",
     "@ledgerhq/tsconfig-dsdk": "workspace:*",
+    "@ledgerhq/prettier-config-dsdk": "workspace:*",
     "concurrently": "^8.2.2",
     "ts-node": "^10.9.2",
     "tsc-alias": "^1.8.8"

packages/core/src/di.ts

@@ -14,7 +14,7 @@ export const makeContainer = ({
   const container = new Container();
   container.applyMiddleware(logger);
   container.load(
-    configModuleFactory({ stub })
+    configModuleFactory({ stub }),
     // modules go here
   );
 

packages/core/src/internal/config/data/LocalConfigDataSource.test.ts

@@ -26,7 +26,7 @@ describe("LocalConfigDataSource", () => {
 
     it("should return an Either<never, Config>", () => {
       readFileSyncSpy.mockReturnValue(
-        JSON.stringify({ name: "DeviceSDK", version: "0.0.0-spied.1" })
+        JSON.stringify({ name: "DeviceSDK", version: "0.0.0-spied.1" }),
       );
 
       jsonParse.mockReturnValue({
@@ -38,7 +38,7 @@ describe("LocalConfigDataSource", () => {
         Either.of({
           name: "DeviceSDK",
           version: "0.0.0-spied.1",
-        })
+        }),
       );
     });
 
@@ -54,7 +54,7 @@ describe("LocalConfigDataSource", () => {
     it("should return an Either<JSONParseError, never> if JSON.parse throws", () => {
       const err = new Error("JSON.parse error");
       readFileSyncSpy.mockReturnValue(
-        JSON.stringify({ name: "DeviceSDK", version: "0.0.0-spied.1" })
+        JSON.stringify({ name: "DeviceSDK", version: "0.0.0-spied.1" }),
       );
 
       jsonParse.mockImplementation(() => {
@@ -71,7 +71,7 @@ describe("LocalConfigDataSource", () => {
         JSON.stringify({
           name: "@ledgerhq/device-sdk-core",
           version: "0.0.1",
-        })
+        }),
       );
     });
   });

packages/core/src/internal/config/data/LocalConfigDataSource.ts

@@ -37,7 +37,7 @@ export class FileLocalConfigDataSource implements LocalConfigDataSource {
           (error) => {
             console.log("JSON.parse error");
             return new JSONParseError(error);
-          }
+          },
         );
       });
   }

packages/core/src/internal/config/data/RemoteConfigDataSource.stub.ts

@@ -17,8 +17,8 @@ export class StubRemoteConfigDataSource implements RemoteConfigDataSource {
         Either.of({
           name: "DeviceSDK",
           version: "0.0.0-fake.2",
-        })
-      )
+        }),
+      ),
     );
   }
 }

packages/core/src/internal/config/data/RemoteConfigDataSource.test.ts

@@ -15,11 +15,11 @@ let datasource: RemoteConfigDataSource;
 /* eslint-disable @typescript-eslint/no-explicit-any */
 const callApiSpy = jest.spyOn(
   RestRemoteConfigDataSource.prototype as any,
-  "_callApi"
+  "_callApi",
 );
 const parseResponseSpy = jest.spyOn(
   RestRemoteConfigDataSource.prototype as any,
-  "_parseResponse"
+  "_parseResponse",
 );
 /* eslint-enable @typescript-eslint/no-explicit-any */
 
@@ -37,23 +37,23 @@ describe("RemoteRestConfigDataSource", () => {
           ok: true,
           json: () =>
             Promise.resolve(
-              Either.of({ name: "DeviceSDK", version: "0.0.0-fake.1" })
+              Either.of({ name: "DeviceSDK", version: "0.0.0-fake.1" }),
             ),
-        })
+        }),
       );
 
       parseResponseSpy.mockReturnValue(
         Either.of({
           name: "DeviceSDK",
           version: "0.0.0-fake.1",
-        })
+        }),
       );
 
       expect(await datasource.getConfig()).toStrictEqual(
         Either.of({
           name: "DeviceSDK",
           version: "0.0.0-fake.1",
-        })
+        }),
       );
     });
 
@@ -62,7 +62,7 @@ describe("RemoteRestConfigDataSource", () => {
       callApiSpy.mockResolvedValue(Left(err));
 
       expect(await datasource.getConfig()).toStrictEqual(
-        Left(new ApiCallError(err))
+        Left(new ApiCallError(err)),
       );
     });
 
@@ -72,13 +72,13 @@ describe("RemoteRestConfigDataSource", () => {
           ok: false,
           json: () =>
             Promise.resolve(
-              Either.of({ name: "DeviceSDK", version: "0.0.0-fake.1" })
+              Either.of({ name: "DeviceSDK", version: "0.0.0-fake.1" }),
             ),
-        })
+        }),
       );
 
       expect(await datasource.getConfig()).toStrictEqual(
-        Left(new ApiCallError(new Error("response not ok")))
+        Left(new ApiCallError(new Error("response not ok"))),
       );
     });
 
@@ -88,11 +88,11 @@ describe("RemoteRestConfigDataSource", () => {
         Either.of({
           ok: true,
           json: () => Promise.resolve(Left(err)),
-        })
+        }),
       );
 
       expect(await datasource.getConfig()).toStrictEqual(
-        Left(new JSONParseError())
+        Left(new JSONParseError()),
       );
     });
 
@@ -102,17 +102,17 @@ describe("RemoteRestConfigDataSource", () => {
           ok: true,
           json: () =>
             Promise.resolve(
-              Either.of({ name: "DeviceSDK", version: "0.0.0-fake.1" })
+              Either.of({ name: "DeviceSDK", version: "0.0.0-fake.1" }),
             ),
-        })
+        }),
       );
 
       parseResponseSpy.mockImplementation(() => {
         return Left(new ParseResponseError());
       });
 
       expect(await datasource.getConfig()).toStrictEqual(
-        Left(new ParseResponseError())
+        Left(new ParseResponseError()),
       );
     });
 
@@ -126,13 +126,13 @@ describe("RemoteRestConfigDataSource", () => {
               Either.of({
                 version: "0.0.0-fake.1",
                 yolo: "yolo",
-              })
+              }),
             ),
-        })
+        }),
       );
 
       expect(await datasource.getConfig()).toStrictEqual(
-        Left(new ParseResponseError())
+        Left(new ParseResponseError()),
       );
     });
 
@@ -147,7 +147,7 @@ describe("RemoteRestConfigDataSource", () => {
           Either.of({
             name: "DeviceSDK",
             version: "0.0.0-fake.1",
-          })
+          }),
         );
       });
     });

packages/core/src/internal/config/data/RemoteConfigDataSource.ts

@@ -72,10 +72,10 @@ export class RestRemoteConfigDataSource implements RemoteConfigDataSource {
                   name: "DeviceSDK",
                   version: "0.0.0-fake.1",
                   yolo: "yolo",
-                })
+                }),
               );
             }),
-        })
+        }),
       );
     });
   }

packages/core/src/internal/config/service/DefaultConfigService.test.ts

@@ -28,7 +28,7 @@ describe("DefaultConfigService", () => {
         Either.of({
           name: "DeviceSDK",
           version: "1.0.0-local",
-        })
+        }),
       );
 
       expect(await service.getSdkConfig()).toStrictEqual({
@@ -45,7 +45,7 @@ describe("DefaultConfigService", () => {
         Either.of({
           name: "DeviceSDK",
           version: "1.0.0-remote",
-        })
+        }),
       );
 
       expect(await service.getSdkConfig()).toStrictEqual({

packages/core/src/internal/config/service/DefaultConfigService.ts

@@ -15,7 +15,7 @@ export class DefaultConfigService implements ConfigService {
   private _remote: RemoteConfigDataSource;
   constructor(
     @inject(types.LocalConfigDataSource) local: LocalConfigDataSource,
-    @inject(types.RemoteConfigDataSource) remote: RemoteConfigDataSource
+    @inject(types.RemoteConfigDataSource) remote: RemoteConfigDataSource,
   ) {
     this._local = local;
     this._remote = remote;

packages/core/tsconfig.json

@@ -5,7 +5,7 @@
     "baseUrl": ".",
     "paths": {
       "@internal/*": ["src/internal/*"],
-      "@root/*": ["./*"],
+      "@root/*": ["./*"]
     }
   },
   "include": ["src", "index.ts", "jest.*.ts"]

packages/signer/.prettierrc.js

@@ -0,0 +1,3 @@
+module.exports = {
+  ...require("@ledgerhq/prettier-config-dsdk"),
+};

packages/signer/package.json

@@ -12,6 +12,8 @@
     "dev": "tsc --watch",
     "lint": "eslint --cache --ext .ts \"src\" --max-warnings=0",
     "lint:fix": "eslint --cache --fix --ext .ts \"src\"",
+    "prettier": "prettier . --check",
+    "prettier:fix": "prettier . --write",
     "test": "jest --passWithNoTests"
   },
   "dependencies": {
@@ -21,6 +23,7 @@
   "devDependencies": {
     "@ledgerhq/tsconfig-dsdk": "workspace:*",
     "@ledgerhq/eslint-config-dsdk": "workspace:*",
-    "@ledgerhq/jest-config-dsdk": "workspace:*"
+    "@ledgerhq/jest-config-dsdk": "workspace:*",
+    "@ledgerhq/prettier-config-dsdk": "workspace:*"
   }
 }

packages/signer/tsconfig.json

@@ -3,5 +3,5 @@
   "compilerOptions": {
     "outDir": "./lib"
   },
-  "include": ["src/**/*", "jest.config.ts"],
+  "include": ["src/**/*", "jest.config.ts"]
 }

packages/trusted-apps/.prettierrc.js

@@ -0,0 +1,3 @@
+module.exports = {
+  ...require("@ledgerhq/prettier-config-dsdk"),
+};