Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DSDK-196][FEAT][OTHR] Add prettier configuration #20

Merged
merged 3 commits into from
Feb 12, 2024

Conversation

aussedatlo
Copy link
Contributor

@aussedatlo aussedatlo commented Feb 8, 2024

πŸ“ Description

Add prettier configuration for sample and all packages.

❓ Context

βœ… Checklist

Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.

  • Covered by automatic tests.
  • Impact of the changes:
    • ...

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.

Copy link

vercel bot commented Feb 8, 2024

@aussedatlo is attempting to deploy a commit to the LedgerHQ Team on Vercel.

To accomplish this, @aussedatlo needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

Copy link
Member

@valpinkman valpinkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You even added the script to turbo and root package.json

(-β– _β– )

@aussedatlo aussedatlo force-pushed the feature/DSDK-196-prettier branch from 8e0c266 to 37e130c Compare February 8, 2024 11:07
@aussedatlo aussedatlo force-pushed the feature/DSDK-196-prettier branch from 37e130c to 8b3f1bc Compare February 12, 2024 13:54
@aussedatlo aussedatlo merged commit 13ea323 into develop Feb 12, 2024
3 of 4 checks passed
@valpinkman valpinkman deleted the feature/DSDK-196-prettier branch February 12, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants