-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8GeV config added for inclusive sample #1272
8GeV config added for inclusive sample #1272
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't want a new file called ..._8gev
but actually an update to the existing file. 8 GeV is our new default and this should be reflected in our CI configs. Changing the original file also makes it easier to review your exact changes in the pull request.
by the way i expect the associated test to break if you rename the existing file, since two different beam energies are compared. that is ok. it would be good to just take a quick look at the resulting histograms ("artifacts") that the diffrences are expected, just as you have done for validation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides a niche output-filename change that is required for the CI, I can't think of anything else to change. As @bryngemark said, this will fail the PR Validation histograms but those histograms will be interesting to look at.
I think this needs to go in before we change the CI configs to add the debug level info as discussed in #1277 (comment) |
I am updating ldmx-sw, here are the details.
Check List
I successfully compiled ldmx-sw with my developments
I ran my developments and the following shows that they are successful.
Link to presentation
To run this config :