Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable debug-level to the terminal in validation sample configs #1281

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

tomeichlersmith
Copy link
Member

not doing it in the configs that prepare input files for it_pileup since both of those configs are tested elsewhere already (inclusive and ecal_pn).

What are the issues that this addresses?

This resolves #1280
.

I am leaving the testing to the CI. This should fail all of the validation tests but only when checking the logs.

not doing it in the configs that prepare input files for it_pileup
since both of those configs are tested elsewhere already (inclusive
and ecal_pn)
@tomeichlersmith
Copy link
Member Author

The only CI differences are log based or due to #1272 in the inclusive sample. Going to go ahead and merge this now.

@tomeichlersmith tomeichlersmith marked this pull request as ready for review April 10, 2024 18:11
@tomeichlersmith tomeichlersmith merged commit cfe98a0 into trunk Apr 10, 2024
2 of 8 checks passed
@tomeichlersmith tomeichlersmith deleted the 1280-debug-in-ci branch April 10, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI tests should use debug option to make the logs
2 participants