Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace legacy app bridge with app bridge cdn #361

Merged

Conversation

enmaboya
Copy link
Contributor

@enmaboya enmaboya commented Nov 11, 2024

  1. The code related to Turbolinks has been removed because Turbolinks has not been supported or maintained since 2021.
  2. No separate support for Livewire has been added either, as the approach differs between Livewire 2 and Livewire 3. It might be better to add this information to the README later.

@enmaboya enmaboya marked this pull request as ready for review November 11, 2024 14:46
@enmaboya enmaboya force-pushed the replace_legacy_app_bridge_with_app_bridge_cdn branch from b0711d5 to 78aaa4f Compare November 11, 2024 14:52
@Kyon147
Copy link
Owner

Kyon147 commented Nov 11, 2024

I've just seen you complete this just before I pushed up my update #362 so I am going to close mine in favour of yours and will review it shortly.

Thanks @enmaboya

@Kyon147 Kyon147 self-requested a review November 12, 2024 09:56
Force https on the url if there is one from the origin. This can help with some ngrok issues when testing locally and stops mix matched requests.
Copy link
Owner

@Kyon147 Kyon147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @enmaboya

Great work with this.

I have made some edits, bringing in some of my changes as I wanted to make token/auth more robust and throw an error when host is missing to help with development.

Also, I still want test coverage for the api key for the new meta key, so have added that back into the Home controller test

@VivekShingala
Copy link

Thanks, @enmaboya for this PR. I patched it and it worked for my Shopify app.

@Kyon147 Thank you for approving the PR and merging it. However, when will it be ready to update using Composer? Currently, it's showing the latest version v21.2.0 from September.

@Kyon147
Copy link
Owner

Kyon147 commented Nov 14, 2024

@VivekShingala the new release is going to be sometime later today 👍

@Kyon147 Kyon147 merged commit 3e99d44 into Kyon147:master Nov 14, 2024
10 checks passed
@VivekShingala
Copy link

@VivekShingala the new release is going to be sometime later today 👍

Thanks a lot @Kyon147

@jsalguero94
Copy link

Hi @Kyon147 @enmaboya , I just updated to the new version and I got this error when I tried to install the app in Shopify. This did not happen with the previous version. I'm using Blade and I have made a migrate:fresh and cleared the cache several times. thanks

image

@d-shannon
Copy link
Contributor

Great work on this @enmaboya! Running smoothly for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants