-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace legacy app bridge with app bridge cdn #361
Replace legacy app bridge with app bridge cdn #361
Conversation
enmaboya
commented
Nov 11, 2024
•
edited
Loading
edited
- The code related to Turbolinks has been removed because Turbolinks has not been supported or maintained since 2021.
- No separate support for Livewire has been added either, as the approach differs between Livewire 2 and Livewire 3. It might be better to add this information to the README later.
b0711d5
to
78aaa4f
Compare
Force https on the url if there is one from the origin. This can help with some ngrok issues when testing locally and stops mix matched requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @enmaboya
Great work with this.
I have made some edits, bringing in some of my changes as I wanted to make token/auth more robust and throw an error when host is missing to help with development.
Also, I still want test coverage for the api key for the new meta key, so have added that back into the Home controller test
@VivekShingala the new release is going to be sometime later today 👍 |
Thanks a lot @Kyon147 |
Great work on this @enmaboya! Running smoothly for me. |