Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing issues #41

Merged
merged 13 commits into from
Oct 19, 2023
Merged

Fixing issues #41

merged 13 commits into from
Oct 19, 2023

Conversation

dkoslicki
Copy link
Member

Fixes #34, #37, #38, #39, and #40

@dkoslicki dkoslicki requested a review from mfl15 October 18, 2023 20:27
@dkoslicki
Copy link
Member Author

Note @KoslickiLab/koslicki-lab: There is a new test in tests/test_workflow.py called test_demo_workflow which essentially contains the quickstart demo code. These two should be kept in sync (if you change one, be sure to change the other)

mlupei
mlupei previously approved these changes Oct 19, 2023
View reviewed changes
@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dkoslicki dkoslicki requested a review from mlupei October 19, 2023 17:56
@dkoslicki dkoslicki merged commit edc6ba5 into main Oct 19, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlupei mlupei mlupei approved these changes

@mfl15 mfl15 Awaiting requested review from mfl15

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make test and runtime check for only single sketch in .zip file for the sample
2 participants
@dkoslicki @mlupei