-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: return partial reports without failure #45
Conversation
bc9d266
to
8884711
Compare
8884711
to
689fecf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple lingering comments from others which I agree should be resolved before we move on. For instance: I do particularly want to see us get of logrus if feasible. After that LGTM.
Do you suggest that we try to remove What would you like to replace it with? I've asked @jrsmroz today and he mentioned that logger work was deprioritized (punted to v3 of KIC) last time we looked at it (in here Kong/kubernetes-ingress-controller#1893) and with that the consensus around what to use instead. |
689fecf
to
d3dbcd2
Compare
If you don't see a quick win in terms of removing the old deprecated logger, then I'm OK with us simply creating a follow-up issue as a resolution here. |
Created: to track that |
This PR aims to address #42 which will make the framework to return reports - even if they're partial - to the caller.
This will have the benefit of returning (and forwarding) even small traces of information instead of simply dropping it on the floor.