Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manager: don't abort collecting providers' reports when encountering errors #42

Closed
pmalek opened this issue Aug 9, 2022 · 0 comments · Fixed by #45
Closed

manager: don't abort collecting providers' reports when encountering errors #42

pmalek opened this issue Aug 9, 2022 · 0 comments · Fixed by #45
Assignees
@pmalek

Comments

@pmalek
Copy link
Member

pmalek commented Aug 9, 2022

Related TODO comment:

kubernetes-telemetry/pkg/telemetry/manager.go

Lines 194 to 196 in fe6d3b8

// TODO: return true and don't abort when encountering an error.
// Better to report partial report than nothing. In order to do so
// use an error agreggator like https://github.com/hashicorp/go-multierror.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmalek pmalek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: return partial reports without failure Kong/kubernetes-telemetry
1 participant
@pmalek