feat: add hostname, uptime and gateway count providers #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more providers, specifically:
Open questions/issues
For some bizarre reason I can't get gateway counting to work in testing (mocked) environment.
When I don't register the custom
GatewayList
type as seen in tests in this PR, I get the following error:where a sharp eye can spot
Resource=gatewaies:GatewayList gateway.network ing.k8s.io/v1beta1
which to me should begateways
(?).Quick google search shows an issue in kubernetes/client-go#1082 (comment).
EDIT: It seems there's a fix for the above: kubernetes/kubernetes#110053.
If I understand it correctly this will require https://github.com/kubernetes/kubernetes/tree/master/staging 's
apimachinery
dir to be synced out to https://github.com/kubernetes/apimachinery and then a release of that.