Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pypi-publish.yml #99

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Update pypi-publish.yml #99

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81a0696
Update pypi-publish.yml
jonasscheid Jan 10, 2024
78e0c9e
Update pypi-publish.yml
jonasscheid Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/pypi-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
name: Publish tagged release on PyPI
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@master
- uses: actions/checkout@v4
- name: Install utilities
run: sudo apt-get install -y mmv
- name: Set up Python 3.7
Expand Down Expand Up @@ -37,11 +37,11 @@ jobs:
mmv -v dist/'*.*.*-*' dist/'#1.#2.#3-'$timestamp'-#4'
Copy link
Collaborator Author

@jonasscheid jonasscheid Jan 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christopher-mohr what was the rationale behind this timestamp? afaik that prevents bioconda from automatically bumping the version when a new release is published on pypi no?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure who added this initially to be honest. Do you have a link to docs for that?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you can create receips with conda skeleton :https://bioconda.github.io/contributor/guidelines.html#python

And all packages that I created via this are autobumped if the version of pypi is also bumped

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the connection to the time stamp at the moment. But in general I do not insist on keeping them.

mmv -v dist/'*.tar.gz' dist/'#1-'$timestamp.tar.gz
- name: Publish distribution package to PyPI (test)
uses: pypa/gh-action-pypi-publish@master
uses: pypa/gh-action-pypi-publish@release/v1
with:
password: ${{ secrets.TEST_PYPI_API_TOKEN }}
repository_url: https://test.pypi.org/legacy/
- name: Publish distribution package to PyPI (production)
uses: pypa/gh-action-pypi-publish@master
uses: pypa/gh-action-pypi-publish@release/v1
with:
password: ${{ secrets.PYPI_API_TOKEN }}