Update pypi-publish.yml #99
Conversation
Warning after release: >Publish tagged release on PyPI Input 'password' has been deprecated with message: UNSUPPORTED GITHUB ACTION VERSION You are using `pypa/gh-action-pypi-publish@master`. The `master` branch of this project has been sunset and will not receive any updates, not even security bug fixes. Please, make sure to use a supported version. If you want to pin to v1 major version, use `pypa/gh-action-pypi-publish@release/v1`. If you feel adventurous, you may opt to use use `pypa/gh-action-pypi-publish@unstable/v1` instead. A more general recommendation is to pin to exact tags or commit SHAs. Please also consider migrading your setup to use secretless publishing: https://github.com/marketplace/actions/pypi-publish#trusted-publishing Adjusted according to https://packaging.python.org/en/latest/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/
.github/workflows/pypi-publish.yml
Outdated
| @@ -37,11 +37,11 @@ jobs: | |||
| mmv -v dist/'*.*.*-*' dist/'#1.#2.#3-'$timestamp'-#4' | |||
There was a problem hiding this comment.
@christopher-mohr what was the rationale behind this timestamp? afaik that prevents bioconda from automatically bumping the version when a new release is published on pypi no?
There was a problem hiding this comment.
Not sure who added this initially to be honest. Do you have a link to docs for that?
There was a problem hiding this comment.
So you can create receips with conda skeleton :https://bioconda.github.io/contributor/guidelines.html#python
And all packages that I created via this are autobumped if the version of pypi is also bumped
There was a problem hiding this comment.
I don't see the connection to the time stamp at the moment. But in general I do not insist on keeping them.
|
Did you find anything on the error message?
|
|
I think it is releated to inserting the timestamp in the filename of the tarball --> https://peps.python.org/pep-0625/#specification |
|
I'll force push from dev to main later if you are fine with this and approved this one |
approved, or just open a PR? Also don't forget to delete the old release |
Warning after release:
Adjusted according to https://packaging.python.org/en/latest/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/