- added ATSAMD21J15/16/17/18A-A

[daviid5]

Datasheet:
http://ww1.microchip.com/downloads/en/DeviceDoc/SAMD21-Family-DataSheet-DS40001882D.pdf

How should be different possible Packages for the same part be handled?
In this case there is also QFN64 possible
I could an Alias, the Footprint in the "Field" Section is set for the whole part (including the aliases).
Is there another possibility?

---

All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

• Provide a URL to a datasheet for the symbol(s) you are contributing
• An example screenshot image is very helpful
• Ensure that the associated footprints match the official footprint library
  • A new fitting footprint must be submitted if the library does not yet contain one.
• If there are matching footprint PRs, provide link(s) as appropriate
• Check the output of the Travis automated check scripts - fix any errors as required
• Give a reason behind any intentional library convention rule violation.

[myfreescalewebpage]

Hi @daviid5 , thanks for contributing,

A few comments I have during my review:

• Datasheet link is not correct, to be fixed, I have used http://ww1.microchip.com/downloads/en/DeviceDoc/SAMD21-Family-DataSheet-DS40001882D.pdf for the review
• Footprint filter should be TQFP*10x10mm*P0.5mm*
• As indicated page 35 of the datasheet, VDDCORE is Power Output

Else, good contribution!

Cheers,
Joel

[myfreescalewebpage]

@daviid5 thanks for the fixes, still missing the fix of the datasheet link. Actually your link redirect to the microchip.com home page.

[myfreescalewebpage]

I'm speaking of the link in the library of course, not in the PR !

[myfreescalewebpage]

@daviid5 any news here ? Still missing fix of datasheet link. Thanks, Joel

[myfreescalewebpage]

@daviid5 ping :)

[daviid5]

@myfreescalewebpage
In my opinion the datasheet link is fixed since the last commit
see:
be33614
datasheet link is: http://ww1.microchip.com/downloads/en/DeviceDoc/SAMD21-Family-DataSheet-DS40001882D.pdf
That one works for me

[myfreescalewebpage]

@daviid5 it works for the ATSAMD21G18A-AUT device but not for the others !
I also just realize you have a modification of the "MCU_Microchip_SAME.dcm" library that is not expected (a datasheet link !)
Please have a look at the git diff at https://github.com/KiCad/kicad-symbols/pull/1623/files
Cheers,
Joel

[daviid5]

@myfreescalewebpage
Now I've got it.
I reverted the changes in the SAME Library now ;)

[myfreescalewebpage]

@daviid5 ok for SAME library, thanks.
However, the following devices have still a bad datasheet link: ATSAMD21J15A-A, ATSAMD21J16A-A, ATSAMD21J17A-A, ATSAMD21J18A-A
Cheers,
Joel

[myfreescalewebpage]

No news from the original author, indicate this PR is abandoned.

[daviid5]

@myfreescalewebpage
sorry, had forgotten this PR, should be fixed now
github says there are 'conflicting files', but I don't understand the problem, could somebody help me out with this?

[myfreescalewebpage]

@daviid5 no worries. master branch on github has moved and you should now update your fork here to reflect the changes.

More help: #145 (comment)

[cpresser]

#2336

[myfreescalewebpage]

Still need to update your fork, I'm not able to finalize the review actually.

[myfreescalewebpage]

https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/syncing-a-fork

[cpresser]

This is a duplicate of #2336
I plan to merge #2336 soon. It is almost finished, is currently active and has a really good quality.

[myfreescalewebpage]

OK thanks @cpresser! Closing this issue.