Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel - React Docs Update #1830

Merged
merged 5 commits into from
Nov 7, 2023
Merged

Panel - React Docs Update #1830

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4ca1418
fix(panel): moves items into variables to fix storybook looping issue
anechol Oct 20, 2023
a9b68bb
docs(panel): updates Panel docs for React
anechol Oct 24, 2023
c1db713
docs(panel): removes note for divider label and adds periods to prop …
anechol Oct 25, 2023
7dc5871
docs(panel): refactors stories and adds canvas control support
anechol Nov 2, 2023
630cf98
docs(panel): adds link to grid templates and updates text for panel row
anechol Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/app/views/examples/components/panel/_preview.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ Ut elementum id leo ac fringilla.

<h3>Body</h3>

There are a few for the panel body container.
There are a few options for the panel body container.

<h4>Panel Block</h4>

Expand Down
6 changes: 6 additions & 0 deletions packages/sage-react/lib/Panel/Panel.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,16 @@ Panel.defaultProps = {
};

Panel.propTypes = {
/** Renders any content passed within. */
children: PropTypes.node,
/** CSS class that will be applied to the outermost container. */
className: PropTypes.string,
/** Removes padding on both top and bottom of the Panel. */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When true, removes padding on both top and bottom of the Panel.

clearPaddingBoth: PropTypes.bool,
/** Removes padding on the bottom of the Panel. */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When true, removes padding on the bottom of the Panel.

clearPaddingBottom: PropTypes.bool,
/** Removes padding on the top of the Panel. */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When true, removes padding on the top of the Panel.

clearPaddingTop: PropTypes.bool,
/** Setting this to true will display a loading spinner within the Panel. */
loading: PropTypes.bool,
};
Loading
Loading