-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panel - React Docs Update #1830
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One note on the divider label and one small nitpick. Really nice update here, great work!
86ef58a
to
7dc5871
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work...I left a few comments, but they are non-blocking
clearPaddingBoth: PropTypes.bool, | ||
/** Removes padding on the bottom of the Panel. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When true, removes padding on the bottom of the Panel.
className: PropTypes.string, | ||
/** Removes padding on both top and bottom of the Panel. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When true, removes padding on both top and bottom of the Panel.
clearPaddingBottom: PropTypes.bool, | ||
/** Removes padding on the top of the Panel. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When true, removes padding on the top of the Panel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of non-blocking suggestions, but overall LGTM! Great work! 👍🏼
3643352
to
7dafcb7
Compare
Description
Updates Panel docs for React.
Testing in
sage-lib
Testing in
kajabi-products
(LOW) Updates Panel docs for React. No effect on Kajabi Products.