Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel - React Docs Update #1830

Merged
merged 5 commits into from
Nov 7, 2023
Merged

Panel - React Docs Update #1830

merged 5 commits into from
Nov 7, 2023

Conversation

anechol
Copy link
Contributor

@anechol anechol commented Oct 24, 2023

Description

Updates Panel docs for React.

Testing in sage-lib

  • Navigate to Panel
  • Check that docs are updated

Testing in kajabi-products

(LOW) Updates Panel docs for React. No effect on Kajabi Products.

@anechol anechol requested a review from a team October 24, 2023 21:27
@anechol anechol self-assigned this Oct 24, 2023
@anechol anechol added the documentation Improvements or additions to documentation label Oct 24, 2023
Copy link
Member

@pixelflips pixelflips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One note on the divider label and one small nitpick. Really nice update here, great work!

packages/sage-react/lib/Panel/Panel.story.mdx Outdated Show resolved Hide resolved
packages/sage-react/lib/Panel/Panel.jsx Outdated Show resolved Hide resolved
@pixelflips pixelflips requested a review from a team October 25, 2023 15:49
@anechol anechol force-pushed the panel-docs-update-react branch from 86ef58a to 7dc5871 Compare November 2, 2023 20:46
@anechol anechol requested review from pixelflips, ju-Skinner and a team November 2, 2023 20:54
Copy link
Collaborator

@ju-Skinner ju-Skinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work...I left a few comments, but they are non-blocking

clearPaddingBoth: PropTypes.bool,
/** Removes padding on the bottom of the Panel. */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When true, removes padding on the bottom of the Panel.

className: PropTypes.string,
/** Removes padding on both top and bottom of the Panel. */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When true, removes padding on both top and bottom of the Panel.

clearPaddingBottom: PropTypes.bool,
/** Removes padding on the top of the Panel. */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When true, removes padding on the top of the Panel.

@ju-Skinner ju-Skinner requested a review from a team November 2, 2023 21:00
Copy link
Member

@pixelflips pixelflips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of non-blocking suggestions, but overall LGTM! Great work! 👍🏼

packages/sage-react/lib/Panel/Panel.story.mdx Outdated Show resolved Hide resolved
packages/sage-react/lib/Panel/Panel.story.mdx Show resolved Hide resolved
packages/sage-react/lib/Panel/Panel.story.mdx Outdated Show resolved Hide resolved
@pixelflips pixelflips requested a review from a team November 2, 2023 21:31
@ju-Skinner ju-Skinner force-pushed the develop branch 2 times, most recently from 3643352 to 7dafcb7 Compare November 6, 2023 15:35
@anechol anechol merged commit 9e76fb7 into develop Nov 7, 2023
4 checks passed
@anechol anechol deleted the panel-docs-update-react branch November 7, 2023 17:08
@QuintonJason QuintonJason mentioned this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants