Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DSS-479] Sortable - Content Width Issue #1819

Closed
wants to merge 3 commits into from
Closed

[DSS-479] Sortable - Content Width Issue #1819

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb70769
chore(ci): updating rails gem version [ci skip]
kajabi-bot Oct 16, 2023
b505ba1
chore(release): publish [skip ci]
kajabi-bot Oct 16, 2023
71efe6b
fix(sortable): fixes issues with title dictating width of content
anechol Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions docs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,26 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# [5.18.0](https://github.com/Kajabi/sage-lib/compare/@kajabi/[email protected]...@kajabi/[email protected]) (2023-10-16)


### Bug Fixes

* **upload card:** align specs, refactor template logic ([c04f9c2](https://github.com/Kajabi/sage-lib/commit/c04f9c23447b804b2f46927982a65e3c0cd93ed5))
* **upload card:** examples, file types and a11y fixes ([28078c4](https://github.com/Kajabi/sage-lib/commit/28078c44ccd449cee81ae3bf8f2fdc253402fdb6))
* **upload card:** fixes issue with content for content is replicated in multiple upload cards ([8dbdb8b](https://github.com/Kajabi/sage-lib/commit/8dbdb8b4977994dee8c6fe1f5e0350878afec47e))
* **upload card:** remove input and label with custom actions ([23efd64](https://github.com/Kajabi/sage-lib/commit/23efd646cf818ad4898d788329fd93f3a26339c3))


### Features

* **upload card:** adjust content areas ([91c7fa8](https://github.com/Kajabi/sage-lib/commit/91c7fa80a3acd8db129aef16215154b297f7969e))
* **upload card:** force stack layout option ([f2536ca](https://github.com/Kajabi/sage-lib/commit/f2536ca7cac07c3f7fc541e3efbca3155271dd0a))





## [5.17.5](https://github.com/Kajabi/sage-lib/compare/@kajabi/[email protected]...@kajabi/[email protected]) (2023-10-02)

**Note:** Version bump only for package @kajabi/sage
Expand Down
2 changes: 1 addition & 1 deletion docs/Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PATH
remote: lib/sage_rails
specs:
sage_rails (5.17.5)
sage_rails (5.18.0)
classy_hash
rails

Expand Down
2 changes: 1 addition & 1 deletion docs/lib/sage_rails/lib/sage_rails/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module SageRails
VERSION = "5.17.5"
VERSION = "5.18.0"
end
4 changes: 2 additions & 2 deletions docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@kajabi/sage",
"version": "5.17.5",
"version": "5.18.0",
"description": "The Sage Design System (SDS) is our single source of truth, providing everything you need to build great products for our customers. It is the culmination of designers and developers working together to give teams the ability to ship high-quality products faster.",
"main": "sage/pages/index",
"directories": {
Expand Down Expand Up @@ -37,7 +37,7 @@
"dependencies": {
"@babel/core": "^7.12.3",
"@babel/plugin-transform-runtime": "^7.12.1",
"@kajabi/sage-packs": "^1.0.45",
"@kajabi/sage-packs": "^1.0.46",
"@rails/webpacker": "5.2.2",
"arrive": "^2.4.1",
"core-js": "^3.6.5",
Expand Down
17 changes: 17 additions & 0 deletions packages/sage-assets/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,23 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# [1.12.0](https://github.com/Kajabi/sage-lib/compare/@kajabi/[email protected]...@kajabi/[email protected]) (2023-10-16)


### Bug Fixes

* **upload card:** align specs, refactor template logic ([c04f9c2](https://github.com/Kajabi/sage-lib/commit/c04f9c23447b804b2f46927982a65e3c0cd93ed5))
* **upload card:** style adjustments ([fde0ba7](https://github.com/Kajabi/sage-lib/commit/fde0ba7b4a9a3941c34b1743bd8821501ec62403))


### Features

* **upload card:** adds stacked layout and id props ([4ccb1ca](https://github.com/Kajabi/sage-lib/commit/4ccb1cab5ac21bae8f07079f23da2cf0068b8166))





## [1.11.7](https://github.com/Kajabi/sage-lib/compare/@kajabi/[email protected]...@kajabi/[email protected]) (2023-09-11)


Expand Down
3 changes: 2 additions & 1 deletion packages/sage-assets/lib/stylesheets/components/_sortable.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ $-sortable-image-height: rem(48px);

.sage-sortable__item {
display: grid;
grid-template-columns: min-content minmax(0, min-content) auto auto;
grid-template-columns: min-content minmax(0, 1fr) auto auto;
gap: sage-spacing(card);
align-items: center;
padding: sage-spacing(xs) sage-spacing(panel);
Expand Down Expand Up @@ -114,6 +114,7 @@ $-sortable-image-height: rem(48px);

.sage-sortable__item-subtitle {
@extend %t-sage-body-xsmall;
@include truncate();
color: sage-color(charcoal, 100);
}

Expand Down
2 changes: 1 addition & 1 deletion packages/sage-assets/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@kajabi/sage-assets",
"version": "1.11.7",
"version": "1.12.0",
"description": "Assets",
"main": "dist/main.css",
"repository": {
Expand Down
8 changes: 8 additions & 0 deletions packages/sage-packs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## [1.0.46](https://github.com/Kajabi/sage-lib/compare/@kajabi/[email protected]...@kajabi/[email protected]) (2023-10-16)

**Note:** Version bump only for package @kajabi/sage-packs





## [1.0.45](https://github.com/Kajabi/sage-lib/compare/@kajabi/[email protected]...@kajabi/[email protected]) (2023-10-02)

**Note:** Version bump only for package @kajabi/sage-packs
Expand Down
6 changes: 3 additions & 3 deletions packages/sage-packs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@kajabi/sage-packs",
"version": "1.0.45",
"version": "1.0.46",
"description": "Sage Packs",
"keywords": [
"sage",
Expand Down Expand Up @@ -31,8 +31,8 @@
"url": "https://github.com/Kajabi/sage-lib/issues"
},
"dependencies": {
"@kajabi/sage-assets": "^1.11.7",
"@kajabi/sage-react": "^1.16.4",
"@kajabi/sage-assets": "^1.12.0",
"@kajabi/sage-react": "^1.17.0",
"@kajabi/sage-system": "^1.2.12"
},
"devDependencies": {
Expand Down
11 changes: 11 additions & 0 deletions packages/sage-react/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,17 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# [1.17.0](https://github.com/Kajabi/sage-lib/compare/@kajabi/[email protected]...@kajabi/[email protected]) (2023-10-16)


### Features

* **upload card:** adds stacked layout and id props ([4ccb1ca](https://github.com/Kajabi/sage-lib/commit/4ccb1cab5ac21bae8f07079f23da2cf0068b8166))





## [1.16.4](https://github.com/Kajabi/sage-lib/compare/@kajabi/[email protected]...@kajabi/[email protected]) (2023-10-02)


Expand Down
4 changes: 2 additions & 2 deletions packages/sage-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@kajabi/sage-react",
"version": "1.16.4",
"version": "1.17.0",
"description": "React Components",
"keywords": [
"react",
Expand Down Expand Up @@ -84,7 +84,7 @@
"webpack-cli": "^3.3.12"
},
"dependencies": {
"@kajabi/sage-assets": "^1.11.7",
"@kajabi/sage-assets": "^1.12.0",
"classnames": "^2.2.6",
"debounce": "^1.2.0",
"focus-trap": "^6.2.2",
Expand Down