Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DSS-479] Sortable - Content Width Issue #1819

Closed
wants to merge 3 commits into from
Closed

Conversation

anechol
Copy link
Contributor

@anechol anechol commented Oct 17, 2023

Description

Fixes an issue with the truncation of the title dictating the width of the content. Both the title and subtitle should be able to truncate independently of the other and the content area should take up 100% of the available space.

Screenshots

Before After
Screenshot 2023-10-17 at 5 00 06 PM Screenshot 2023-10-17 at 4 48 24 PM
Screenshot 2023-10-17 at 4 59 56 PM Screenshot 2023-10-17 at 4 48 43 PM

Testing in sage-lib

  1. Navigate to Sortable
  2. In browser dev tools, add extra text to the subtitle
  3. Check that the content area expands the full length of the grid track
  4. Check that subtitle can expand independently from the title

Testing in kajabi-products

(MEDIUM) Fixes an issue with the truncation of the title dictating the width of the content. Both the title and subtitle should be able to truncate independently of the other and the content area should take up 100% of the available space. Minor UI update but touches multiple parts of the app.

Related

DSS-479

@anechol anechol self-assigned this Oct 17, 2023
@anechol anechol requested a review from a team October 17, 2023 22:20
@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 4 package(s) with unknown licenses.
See the Details below.

License Issues

docs/package.json

PackageVersionLicenseIssue Type
@kajabi/sage-packs^1.0.46NullUnknown License

packages/sage-packs/package.json

PackageVersionLicenseIssue Type
@kajabi/sage-assets^1.12.0NullUnknown License
@kajabi/sage-react^1.17.0NullUnknown License

packages/sage-react/package.json

PackageVersionLicenseIssue Type
@kajabi/sage-assets^1.12.0NullUnknown License
Denied Licenses: LGPL-2.0, AAL, Adobe-2006, Afmparse, Artistic-1.0, Artistic-1.0-cl8, Artistic-1.0-Perl, Beerware, blessing, Borceux, CECILL-B, ClArtistic, Condor-1.1, Crossword, CrystalStacker, diffmark, DOC, EFL-1.0, EFL-2.0, Fair, FSFUL, FSFULLR, Giftware, HPND, IJG, Leptonica, LPL-1.0, LPL-1.02, MirOS, mpich2, NASA-1.3, NBPL-1.0, Newsletr, NLPL, NRL, OGTSL, OLDAP-1.1, OLDAP-1.2, OLDAP-1.3, OLDAP-1.4, psutils, Qhull, Rdisc, RSA-MD, Spencer-86, Spencer-94, TU-Berlin-1.0, TU-Berlin-2.0, Vim, W3C-19980720, W3C-20150513, Wsuipa, WTFPL, xinetd, Zed, Zend-2.0, ZPL-1.1, AGPL-1.0-only, AGPL-1.0-or-later, AGPL-3.0-only, AGPL-3.0-or-later, APSL-1.0, APSL-1.1, APSL-1.2, APSL-2.0, CPAL-1.0, EUPL-1.0, EUPL-1.1, EUPL-1.2, NPOSL-3.0, OSL-1.0, OSL-1.1, OSL-2.0, OSL-2.1, OSL-3.0, RPSL-1.0, SSPL-1.0, CAL-1.0, CAL-1.0-Combined-Work-Exception, Parity-6.0.0, Parity-7.0.0, RPL-1.1, RPL-1.5, EPL-1.0, EPL-2.0, ErlPL-1.1, IPL-1.0, LGPL-2.0-only, LGPL-2.0-or-later, LGPL-2.1-only, LGPL-2.1-or-later, LGPL-2.1, LGPL-3.0-only, LGPL-3.0-or-later, LGPL-3.0, MPL-1.0, MPL-1.1, MPL-2.0, MPL-2.0-no-copyleft-exception, MS-RL, SPL-1.0, BSD-Protection, copyleft-next-0.3.0, copyleft-next-0.3.1, GPL-1.0-only, GPL-1.0-or-later, GPL-1.0, GPL-2.0-only, GPL-2.0-or-later, GPL-2.0, GPL-3.0-only, GPL-3.0-or-later, GPL-3.0, QPL-1.0, Sleepycat

Scanned Manifest Files

docs/package.json
  • @kajabi/sage-packs@^1.0.46
  • @kajabi/sage-packs@^1.0.45
packages/sage-packs/package.json
  • @kajabi/sage-assets@^1.12.0
  • @kajabi/sage-react@^1.17.0
  • @kajabi/sage-assets@^1.11.7
  • @kajabi/sage-react@^1.16.4
packages/sage-react/package.json
  • @kajabi/sage-assets@^1.12.0
  • @kajabi/sage-assets@^1.11.7

@anechol anechol force-pushed the sortable-width-bug branch from 11a9352 to 71efe6b Compare October 17, 2023 22:21
Copy link
Member

@pixelflips pixelflips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing some odd file changes, can you confirm those are needed?

e.g. - changelog, gemfile, version, etc...

@pixelflips pixelflips requested a review from a team October 17, 2023 22:38
@anechol anechol closed this Oct 18, 2023
@anechol anechol deleted the sortable-width-bug branch October 18, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants