review requested #1
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
| // Use IntelliSense to learn about possible attributes. | ||
| // Hover to view descriptions of existing attributes. | ||
| // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387 | ||
| "version": "0.2.0", | ||
| "configurations": [ | ||
|
|
||
| { | ||
| "type": "node", | ||
| "request": "launch", | ||
| "name": "Launch Program", | ||
| "skipFiles": [ | ||
| "<node_internals>/**" | ||
| ], | ||
| "program": "${workspaceFolder}/script.js" | ||
| } | ||
| ] | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment. Great job getting everything working up to level-300! I think it was optional anyway, but the only thing missing in terms of functionality is being able to easily go back to seeing all episodes after using the dropdown - the only way to get them back right now is to start typing and then delete again. I think in terms of style/readability, it's good to break up code into some smaller sub-functions - it can make the code much easier to read (because usually a function says what it does), and easier for you to think about too. There is a lot happening in these functions! And the 300 level bit could be put ("encapsulated") in a function. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,102 @@ | ||
| let allEpisodes = getAllEpisodes(); | ||
| function setup() { | ||
| //let allEpisodes = getAllEpisodes(); | ||
| makePageForEpisodes(allEpisodes); | ||
| } | ||
|
|
||
| //level 100 | ||
| //showing all episodes | ||
|
|
||
| function makePageForEpisodes(episodeList) { | ||
| let rootElem = document.getElementById("root"); | ||
| // rootElem.textContent = `Got ${episodeList.length} episode(s)`; | ||
| rootElem.innerHTML = ""; | ||
| for(let episode of episodeList) { | ||
| let divEle = document.createElement("div"); | ||
| divEle.className = "card"; | ||
|
|
||
| const episodeName =document.createElement("h1"); | ||
| episodeName.innerText = `${episode.name}-S${(String(episode.season).padStart(2,'0'))}E${String(episode.number).padStart(2,'0')}`; | ||
| const lineEle = document.createElement("div"); | ||
| lineEle.className = "l"; | ||
|
|
||
|
|
||
| const image = document.createElement("img"); | ||
| image.src = episode.image.medium; | ||
|
|
||
| const episodeSummary = document.createElement("p"); | ||
| episodeSummary.innerHTML = episode.summary; | ||
|
|
||
| divEle.append( | ||
| episodeName, | ||
| lineEle, | ||
| image, | ||
|
There was a problem hiding this comment. i learn from you too :) i didn't know you can add them all at one go, cool!! |
||
| episodeSummary, | ||
| ); | ||
| rootElem.append(divEle) | ||
| }; | ||
| } | ||
| window.onload = setup; | ||
|
|
||
| //level 200 | ||
| //search bar | ||
|
|
||
| searchEle = document.querySelector("#search") | ||
| searchEle.addEventListener("input", searchEpisode); | ||
|
|
||
| function searchEpisode(){ | ||
| const searchInput = searchEle.value.toLowerCase(); | ||
| const filteredEpisodes = allEpisodes.filter(episode => { | ||
| if (episode.name.toLowerCase().includes(searchInput) || episode.summary.toLowerCase().includes(searchInput)){ | ||
| return episode; | ||
| } | ||
| }) | ||
|
|
||
| document.querySelector("#num").innerText = filteredEpisodes.length; | ||
| makePageForEpisodes(filteredEpisodes); | ||
|
|
||
| } | ||
|
|
||
| //level 300 | ||
| //select bar | ||
|
|
||
| let selectEle = document.querySelector("#selector"); | ||
| let optionEle = document.createElement("option") | ||
| optionEle.innerText= "Select Episodes"; | ||
| selectEle.appendChild(optionEle); | ||
|
|
||
| allEpisodes.forEach(el => { | ||
| let options = document.createElement("option"); | ||
| options.value = el.name; | ||
| options.innerText = `${el.name} - S${el.season.toString().padStart(2, "0")}E${el.number.toString().padStart(2, "0")}`; | ||
|
|
||
|
|
||
| selectEle.appendChild(options); | ||
| }); | ||
|
|
||
| selectEle.addEventListener("change", function () { | ||
| let selected = selectEle.value; | ||
| let episodes = Array.from(document.getElementsByClassName("card")); | ||
|
|
||
| episodes.forEach((episode) => { | ||
| let h1Element = episode.querySelector("h1"); | ||
| if (h1Element.innerText.includes(selected)) { | ||
| episode.style.display = "block"; | ||
| document.querySelector("#num").innerText = 1; | ||
|
|
||
| } else { | ||
| episode.style.display = "none"; | ||
| } | ||
| }); | ||
| }); | ||
|
|
||
| //footer | ||
|
|
||
| let footerEle= document.getElementById("footer"); | ||
| const footerLink = document.createElement("a"); | ||
| footerLink.href = "https://www.tvmaze.com/" | ||
| footerLink.textContent = "data from tvmaze.com"; | ||
| footerEle.appendChild(footerLink); | ||
|
|
||
| window.onload = setup; | ||
|
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,55 @@ | ||
| #root { | ||
| color:black; | ||
| display: flex; | ||
| flex-wrap: wrap; | ||
| justify-content: center; | ||
| } | ||
|
|
||
| .card { | ||
| display: flex; | ||
| flex-direction: column; | ||
| margin : 10px; | ||
| padding : 32px; | ||
| background-color:azure; | ||
| max-width: 300px; | ||
| border-radius: 3%; | ||
| border: 1px solid orchid; | ||
|
|
||
| } | ||
|
|
||
|
|
||
|
|
||
| h1{ | ||
| font-size: 20px; | ||
| } | ||
|
|
||
| .l { | ||
| margin-bottom: 20px; | ||
| border: 1px solid orchid; | ||
|
|
||
| } | ||
|
|
||
|
|
||
| img { | ||
| align-self: center; | ||
| } | ||
|
|
||
| p{ | ||
| text-align: justify; | ||
| } | ||
|
|
||
| #search , #selector { | ||
| color: green; | ||
| padding: 10px; | ||
| border: 2px solid orchid; | ||
| margin-bottom: 20px; | ||
| } | ||
|
|
||
| #footer { | ||
| display: flex; | ||
| flex-direction: row; | ||
| justify-content: center; | ||
| font-size: 20px; | ||
| font-family: cursive; | ||
| color: red; | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VS code settings are usually not committed, you could add this file to your gitignore.